-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Codecov #17304
Adding Codecov #17304
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this is a great start! I didn't realize components
is a new feature codecov recommends instead of flags
so you don't have to upload multiple coverage reports (one for each flag). One caveat I saw there:
if you require per-flag coverage trend information and UI support immediately, then it is recommend to use Flags for the time being
I don't think trend information is necessary right now, but worth noting. We should explore the UI once this is merged to see if we can get the information we want.
We might want to consider a few other pieces before merging:
- Move the config file to
.github/codecov.yml
. I don't see documented support for per-package configs in the docs. Did you find docs for multiple config files in a single repo? - Update the config file to configure a
component
entry for each package that has tests ran onyarn test
- react, colors, upgrade, styles, etc.- Right now the config uses what appears to be the simpler way to configure
components
. We might need to use the more advancedcomponent_management
config option so we can configure thresholds for each package.
- Right now the config uses what appears to be the simpler way to configure
- Make the status checks non-blocking for now
What do you think about these?
Hey @tay1orjones And one other thing. It is the first time I configured a SHA. I kinda follow what you did in your PR here, and grabbed the last commit from the action that I need, which it is this one, but I'm not sure if that is the right way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I confirmed the SHA matches the tagged release in the repo for that action.
3e92444
Hey there! v11.66.0 was just released that references this issue/PR. |
Closes #17124
This PR is adding Codecov to make sure we are aware of testing when updating or creating a component. Codecov only has access to carbon repository.
We will not see any CI or comments in this PR. We first need to merge this PR so Codecov will sync everything.
Changelog
New
CODECOV_TOKEN
to settings insidecarbon
repository.Settings > GitHub Apps
codecov.yml
to configure the codecov.Changed
--collectCoverage
to push the report to CodecovTesting / Reviewing
PR example: fix: removed accordion test guidari/carbon#6
Branch that simulates main branch: https://github.com/guidari/carbon/tree/main-codecov