fix(search): keyboard support for enter key #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonjoseph
requested review from
tay1orjones and
guidari
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for gatsby-theme-carbon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1524
Fix so enter key
Changelog
Testing
Search for something that has results and hit enter, it should navigate the first item selected in the results list, or the item you have navigated to by keyboard.