Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed tab navigation in SideNav #1567

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Jan 17, 2025

Closes carbon-design-system/carbon-website#4421

Fixed SideNav navigation for the Carbon Website.

Testing

  • To test the fix you have to pull down locally and remove this piece of code:

Code to be removed in nav-items.yaml
Screenshot 2025-01-17 at 10 11 30

@guidari guidari requested review from eng618 and a team as code owners January 17, 2025 13:13
@guidari guidari requested review from kennylam and annawen1 and removed request for a team January 17, 2025 13:13
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gatsby-theme-carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 3:02pm

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to move the the window.matchMedia call inside useEffect since window doesn’t exist during build time. I tested locally and I think my suggestion will work.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for gatsby-theme-carbon ready!

Name Link
🔨 Latest commit 5bcdfa6
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-carbon/deploys/678a6dd3639b250008c6d95c
😎 Deploy Preview https://deploy-preview-1567--gatsby-theme-carbon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for gatsby-theme-carbon ready!

Name Link
🔨 Latest commit 0133e0e
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-carbon/deploys/678a70331d7f800008bb0955
😎 Deploy Preview https://deploy-preview-1567--gatsby-theme-carbon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard navigation on carbondesignsystem.com is broken
2 participants