-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed tab navigation in SideNav #1567
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to move the the window.matchMedia call inside useEffect since window doesn’t exist during build time. I tested locally and I think my suggestion will work.
packages/gatsby-theme-carbon/src/components/LeftNav/LeftNavItem.js
Outdated
Show resolved
Hide resolved
packages/gatsby-theme-carbon/src/components/LeftNav/ResourceLinks.js
Outdated
Show resolved
Hide resolved
…m.js Co-authored-by: Alison Joseph <[email protected]>
…nks.js Co-authored-by: Alison Joseph <[email protected]>
✅ Deploy Preview for gatsby-theme-carbon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gatsby-theme-carbon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes carbon-design-system/carbon-website#4421
Fixed SideNav navigation for the Carbon Website.
Testing
Code to be removed in
nav-items.yaml