Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(borders, overflows): implements css logical props #6768

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+108 −1
Open

refactor(borders, overflows): implements css logical props #6768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5004f85
refactor(borders): implements css logical props and adds stylelint rule
AlexanderMelox Jan 27, 2025
e9b8a6d
Revert "refactor(borders): implements css logical props and adds styl…
AlexanderMelox Jan 29, 2025
505763b
refactor: also adds overflows
AlexanderMelox Jan 29, 2025
07233c8
Merge branch 'main' into refactor--css-logical-properties-border
sangeethababu9223 Jan 30, 2025
2b663a0
refactor(overflows): adds supports at-rules
AlexanderMelox Jan 31, 2025
14181b3
Update examples/carbon-for-ibm-products/PageHeader/src/Example/_examp…
AlexanderMelox Jan 31, 2025
a041597
Merge branch 'main' into refactor--css-logical-properties-border
AlexanderMelox Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/carbon-for-ibm-products/PageHeader/src/Example/_example.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,7 @@
padding: 0;
margin-top: 3rem;
overflow-y: auto;
@supports (overflow-block: auto) {
overflow-block: auto;
}
}
4 changes: 4 additions & 0 deletions examples/carbon-for-ibm-products/example-gallery/src/components/_Gallery.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ $block-class: 'gallery';

body {
overflow-x: hidden;

@supports (overflow-inline: hidden) {
overflow-inline: hidden;
}
}

.#{$block-class}.#{$block-class} {
Expand Down
4 changes: 4 additions & 0 deletions packages/ibm-products-styles/src/components/AddSelect/_add-select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,10 @@ $tearsheet-class: #{$pkg-prefix}--tearsheet;
flex-grow: 1;
overflow-x: auto;

@supports (overflow-inline: auto) {
overflow-inline: auto;
}

.#{$block-class}__selections-form-control-label-wrapper {
margin-inline-start: $spacing-03;
}
Expand Down
4 changes: 4 additions & 0 deletions packages/ibm-products-styles/src/components/ComboButton/_combo-button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@
.#{c4p-settings.$pkg-prefix}--combo-button__action {
display: block;
overflow-x: hidden;
@supports (overflow-inline: hidden) {
overflow-inline: hidden;
}

text-overflow: ellipsis;
white-space: nowrap;
}
Expand Down
11 changes: 11 additions & 0 deletions packages/ibm-products-styles/src/components/CreateFullPage/_create-full-page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ $step-block-class: #{c4p-settings.$pkg-prefix}--create-full-page__step;
grid-column: 1 / -1;
grid-row: 1 / -1;
overflow-y: auto;
@supports (overflow-block: auto) {
overflow-block: auto;
}
}

.#{$block-class} .#{$block-class}__body {
Expand All @@ -104,6 +107,10 @@ $step-block-class: #{c4p-settings.$pkg-prefix}--create-full-page__step;
background-color: $background;
color: $text-primary;
overflow-x: hidden;
@supports (overflow-inline: hidden) {
overflow-inline: hidden;
}

padding-block-start: $spacing-06;
}

Expand All @@ -123,6 +130,10 @@ $step-block-class: #{c4p-settings.$pkg-prefix}--create-full-page__step;
grid-row: 1;
inset-block-start: 0;
overflow-x: auto;
@supports (overflow-inline: auto) {
overflow-inline: auto;
}

padding-block-start: 0;
}

Expand Down
3 changes: 3 additions & 0 deletions packages/ibm-products-styles/src/components/CreateInfluencer/_create-influencer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ $influencerAnimationStart: calc(-1 * #{$spacing-05});
grid-column: 1 / -1;
grid-row: 1 / -1;
overflow-y: auto;
@supports (overflow-block: auto) {
overflow-block: auto;
}
}

.#{$influencer-block-class}__title {
Expand Down
4 changes: 4 additions & 0 deletions packages/ibm-products-styles/src/components/CreateTearsheet/_create-tearsheet.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ $tearsheet-fieldset-class: #{c4p-settings.$pkg-prefix}--tearsheet-create__step--
.#{$create-tearsheet-block-class} .#{$create-tearsheet-block-class}__content {
min-block-size: 100%;
overflow-x: hidden;
@supports (overflow-inline: hidden) {
overflow-inline: hidden;
}

padding-block: $spacing-06;
}

Expand Down
4 changes: 4 additions & 0 deletions packages/ibm-products-styles/src/components/Datagrid/_datagrid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ $block-class: #{c4p-settings.$pkg-prefix}--datagrid;
// newer version of carbon pagination has scroll which doesn't make any sense, removing it
/* stylelint-disable-next-line declaration-property-value-disallowed-list */
overflow-x: unset;
@supports (overflow-inline: unset) {
/* stylelint-disable-next-line declaration-property-value-disallowed-list */
overflow-inline: unset;
}
}
}
}
Expand Down
18 changes: 18 additions & 0 deletions packages/ibm-products-styles/src/components/Datagrid/styles/_datagrid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,10 @@
block-size: 100%;
inline-size: 100%;
overflow-x: auto;
@supports (overflow-inline: auto) {
/* stylelint-disable-next-line declaration-property-value-disallowed-list */
overflow-inline: auto;
}
}

.#{$block-class}-filter-panel
Expand Down Expand Up @@ -510,6 +514,9 @@
.#{$block-class}__grid-container
table.#{$block-class}__table-simple.#{c4p-settings.$carbon-prefix}--data-table.#{$block-class}__table-is-resizing {
overflow-y: hidden;
@supports (overflow-block: hidden) {
overflow-block: hidden;
}
}

.#{$block-class}__resizableColumn {
Expand Down Expand Up @@ -662,6 +669,9 @@
inline-size: 100%;
max-block-size: 100%;
overflow-y: auto;
@supports (overflow-block: auto) {
overflow-block: auto;
}
}

.#{$block-class}__carbon-row-expanded {
Expand Down Expand Up @@ -755,6 +765,10 @@
.#{c4p-settings.$carbon-prefix}--batch-actions
.#{c4p-settings.$carbon-prefix}--batch-actions--active {
overflow-x: hidden;
@supports (overflow-inline: hidden) {
/* stylelint-disable-next-line declaration-property-value-disallowed-list */
overflow-inline: hidden;
}
}

.#{c4p-settings.$pkg-prefix}--datagrid__table-toolbar
Expand Down Expand Up @@ -819,6 +833,10 @@
.#{c4p-settings.$carbon-prefix}--data-table-content {
// overrides default scroll overflow as we handle overflow in thead and tbody separately for virtualScrollContainer variant
overflow-x: hidden;
@supports (overflow-inline: hidden) {
/* stylelint-disable-next-line declaration-property-value-disallowed-list */
overflow-inline: hidden;
}
}
}

Expand Down
4 changes: 4 additions & 0 deletions packages/ibm-products-styles/src/components/Datagrid/styles/_useNestedTable.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
inline-size: calc(100% - #{$spacing-07});
margin-inline-start: $spacing-07;
overflow-x: hidden;
@supports (overflow-inline: hidden) {
/* stylelint-disable-next-line declaration-property-value-disallowed-list */
overflow-inline: hidden;
}

tr.#{variables.$block-class}__carbon-nested-row {
border-inline-start: none;
Expand Down
5 changes: 5 additions & 0 deletions packages/ibm-products-styles/src/components/EditTearsheet/_edit-tearsheet.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ $tearsheet-fieldset-class: #{c4p-settings.$pkg-prefix}--tearsheet-edit__form--fi
.#{$block-class} .#{$block-class}__content {
block-size: 100%;
overflow-x: hidden;
@supports (overflow-inline: hidden) {
/* stylelint-disable-next-line declaration-property-value-disallowed-list */
overflow-inline: hidden;
}

padding-block: $spacing-06;
}

Expand Down
3 changes: 3 additions & 0 deletions packages/ibm-products-styles/src/components/FilterPanel/_filter-panel-search.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,7 @@ $block-class: #{c4p-settings.$pkg-prefix}--filter-panel-search;
/* stylelint-disable-next-line function-no-unknown */
max-block-size: to-rem(320px);
overflow-y: auto;
@supports (overflow-block: auto) {
overflow-block: auto;
}
}
1 change: 1 addition & 0 deletions packages/ibm-products-styles/src/components/PageHeader/_page-header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,7 @@ $duration: 1000ms;
overflow: hidden;
-webkit-box-orient: vertical;
-webkit-line-clamp: 2;
line-clamp: 2;
}

.#{$block-class}__available-row {
Expand Down
4 changes: 4 additions & 0 deletions packages/ibm-products-styles/src/components/SidePanel/_side-panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ $action-set-block-class: #{c4p-settings.$pkg-prefix}--action-set;
.#{$block-class}--scrolls {
overflow: auto;
overflow-x: hidden;
@supports (overflow-inline: hidden) {
/* stylelint-disable-next-line declaration-property-value-disallowed-list */
overflow-inline: hidden;
}
}

.#{$block-class} {
Expand Down
9 changes: 8 additions & 1 deletion packages/ibm-products-styles/src/components/Tearsheet/_tearsheet.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ $motion-duration: $duration-moderate-02;
}

.#{$block-class}__description-tooltip .#{$carbon-prefix}--definition-term {
border-bottom: 0;
border-block-end: 0;
letter-spacing: inherit;
word-break: break-word;
}
Expand Down Expand Up @@ -335,6 +335,9 @@ $motion-duration: $duration-moderate-02;
flex: 0 0 257px; // influencer width 256px plus 1px border
border-inline-end: 1px solid $border-subtle-01;
overflow-y: auto;
@supports (overflow-block: auto) {
overflow-block: auto;
}

// the normal 80% content width inside modals should not apply to influencer content
// apply the class again for higher specificity
Expand Down Expand Up @@ -431,6 +434,10 @@ $motion-duration: $duration-moderate-02;
grid-column: 1 / -1;
grid-row: -1 / -1;
overflow-x: auto;
@supports (overflow-inline: auto) {
/* stylelint-disable-next-line declaration-property-value-disallowed-list */
overflow-inline: auto;
}
}

.#{$block-class}__buttons {
Expand Down
6 changes: 6 additions & 0 deletions packages/ibm-products-styles/src/components/TruncatedList/_truncated-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,16 @@ $block-class: #{c4p-settings.$pkg-prefix}--truncated-list;

.#{$block-class}--expanded .#{$block-class}__list {
overflow-y: auto;
@supports (overflow-block: auto) {
overflow-block: auto;
}
}

.#{$block-class}--expanded-all .#{$block-class}__list {
overflow-y: hidden;
@supports (overflow-block: hidden) {
overflow-block: hidden;
}
}

.#{c4p-settings.$carbon-prefix}--btn.#{$block-class}__button {
Expand Down
6 changes: 6 additions & 0 deletions packages/ibm-products/src/components/CreateFullPage/_storybook-styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ $block-class: #{c4p-settings.$pkg-prefix}--create-full-page;
box-shadow: 0 0 4px 1px $border-subtle-01;
color: $text-primary;
overflow-y: auto;
@supports (overflow-block: auto) {
overflow-block: auto;
}
}

.#{$story-class}__step-fieldset--no-label
Expand Down Expand Up @@ -73,6 +76,9 @@ $block-class: #{c4p-settings.$pkg-prefix}--create-full-page;
.#{$story-class}__viewport .#{$story-class}__content-container {
block-size: 100%;
overflow-y: auto;
@supports (overflow-block: auto) {
overflow-block: auto;
}
}

.#{$story-class}__viewport
Expand Down
3 changes: 3 additions & 0 deletions packages/ibm-products/src/components/FullPageError/_storybook-styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ $story-class: 'full-page-error-stories';
block-size: calc(100% - #{$spacing-09});
margin-block-start: $spacing-09;
overflow-y: auto;
@supports (overflow-block: auto) {
overflow-block: auto;
}
}

.#{$story-class}__viewport {
Expand Down
4 changes: 4 additions & 0 deletions packages/ibm-products/src/components/Guidebanner/_storybook-styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
//
#storybook-root {
overflow-x: hidden;

@supports (overflow-inline: hidden) {
overflow-inline: hidden;
}
}

// The layout has been changed from middle/center to top/left, because
Expand Down
9 changes: 9 additions & 0 deletions packages/ibm-products/src/components/PageHeader/_storybook-styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,17 @@ $story-class: 'page-header-stories';

.#{$story-class}__viewport--scroll {
overflow-y: auto;
@supports (overflow-block: auto) {
overflow-block: auto;
}
}

.#{$story-class}__viewport .#{$story-class}__content-container {
block-size: 100%;
overflow-y: auto;
@supports (overflow-block: auto) {
overflow-block: auto;
}
}

.#{$story-class}__viewport
Expand All @@ -75,6 +81,9 @@ $story-class: 'page-header-stories';

.#{$story-class}__viewport--scroll .#{$story-class}__content-container {
overflow-y: initial;
@supports (overflow-block: initial) {
overflow-block: initial;
}
}

// cspell:disable-next-line
Expand Down
Loading