Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(eslint): upgrade to v9 #6825

Merged
merged 12 commits into from
Feb 3, 2025

Conversation

matthewgallo
Copy link
Member

@matthewgallo matthewgallo commented Jan 31, 2025

Closes #6187

These changes upgrade eslint to v9 and moves our config from .eslintrc.js to eslint.config.mjs, using the new flat config. I picked up where @elycheea left off with this one, so shout out to Elysia 🎉

What did you change?

eslint config related files
Removed some disabling of rules

How did you test and verify your work?

Manually ran npx eslint from project root

@matthewgallo matthewgallo requested a review from a team as a code owner January 31, 2025 14:30
@matthewgallo matthewgallo requested review from anamikaanu96 and paul-balchin-ibm and removed request for a team January 31, 2025 14:30
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 5c1cbc5
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/679cee3728f11e0008ee8479
😎 Deploy Preview https://deploy-preview-6825--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 5c1cbc5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/679cee37d1a2710008c9d8b6
😎 Deploy Preview https://deploy-preview-6825--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.25%. Comparing base (d043ffa) to head (5c1cbc5).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6825      +/-   ##
==========================================
+ Coverage   81.17%   81.25%   +0.08%     
==========================================
  Files         398      397       -1     
  Lines       12956    12949       -7     
  Branches     4283     4281       -2     
==========================================
+ Hits        10517    10522       +5     
+ Misses       2439     2427      -12     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only did the easy part of the update to find the initial blockers 🙈. Thanks for finishing it out!

We also have good timing since System released yesterday so we can update eslint-config-carbon to the full release instead of the RC. 🎉

@matthewgallo matthewgallo requested a review from elycheea January 31, 2025 15:27
Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@elycheea elycheea added this pull request to the merge queue Feb 3, 2025
Merged via the queue into carbon-design-system:main with commit d0b1481 Feb 3, 2025
32 checks passed
@matthewgallo matthewgallo deleted the eslint-v9 branch February 3, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reconfigure eslint config for v9
3 participants