-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(eslint
): upgrade to v9
#6825
Conversation
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6825 +/- ##
==========================================
+ Coverage 81.17% 81.25% +0.08%
==========================================
Files 398 397 -1
Lines 12956 12949 -7
Branches 4283 4281 -2
==========================================
+ Hits 10517 10522 +5
+ Misses 2439 2427 -12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only did the easy part of the update to find the initial blockers 🙈. Thanks for finishing it out!
We also have good timing since System released yesterday so we can update eslint-config-carbon
to the full release instead of the RC. 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
d0b1481
Closes #6187
These changes upgrade
eslint
to v9 and moves our config from.eslintrc.js
toeslint.config.mjs
, using the new flat config. I picked up where @elycheea left off with this one, so shout out to Elysia 🎉What did you change?
eslint config related files
Removed some disabling of rules
How did you test and verify your work?
Manually ran
npx eslint
from project root