feat: CIP-30 extension to capture network magic #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new CIP that extends CIP-0030 to allow dApps to determine the specific network magic number of the connected Cardano network. While the existing
getNetworkId()function only distinguishes between mainnet (1) and testnet (0), this extension enables dApps to identify specific test networks (preview, preprod, etc.) through their magic numbers.Key features:
getNetworkMagic()function undercipXXXXnamespaceThis extension will help dApps better configure themselves based on the specific test network they're connected to, improving the development and testing experience in the Cardano ecosystem.