Move SSE to Matrix #2116
Merged
Move SSE to Matrix #2116
+2,473
−2,589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host Test Results 1 files ±0 1 suites ±0 25m 8s ⏱️ +6s Results for commit dfab792. ± Comparison against base commit 160dab0. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
backspace
force-pushed
the
matrix-sse-cs-7916
branch
from
2288094 to
b2d57db
Compare
backspace
force-pushed
the
matrix-sse-cs-7916
branch
from
b2d57db to
7cd9d2c
Compare
The adapter seems like the place but some interface changes will be needed to make it work cross-environment.
This probably needs to move into another hook…? Or should test realm setup hooks error if it hasn’t been called?
It’s probably at the point that I should stop changing tests to add this setup and make it built-in…???
This was causing the count to be off, the original didn’t have an assertion, just an error.
I hate it??? But what is to be done.
lukemelia
approved these changes
Mar 6, 2025
# Conflicts: # packages/host/tests/acceptance/code-submode/schema-editor-test.ts
I don’t understand why this is happening 😞
backspace
force-pushed
the
matrix-sse-cs-7916
branch
from
1c305e4 to
90144f7
Compare
habdelra
approved these changes
Mar 10, 2025
# Conflicts: # packages/host/app/resources/room.ts # packages/host/app/services/matrix-service.ts
Why???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repurposes existing Matrix “session rooms” (where the auth conversation is conducted) to also broadcast “realm events”, which were formerly transmitted via Server-Sent Events. It includes several TODOs to completely remove the traces of SSE, including:
service:message-serviceno longer needs to exist$REALM/…_messageendpoint for subscribing can be removedIt’s unfortunately a large PR but there were no obvious seams to further decompose it at. Thankfully most of the changes are mechanical, replicated across many files.
The high-level changes to
hosttests are:setupServerEventsand theTestContextWithSSEthat provided itexpectEvents, no more callbacksettledandwaitUntilto ensure realm events have propagatedsetupMockMatrixwhen missing, theMockUtilsit returns is required for realm setup nowOtherwise the changes include:
expectEventhelper in the realm server’srealm-endpoints-test