Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make schema editor field row clickable #2247

Merged
merged 6 commits into from
Mar 7, 2025

Conversation

FadhlanR
Copy link
Contributor

@FadhlanR FadhlanR commented Mar 6, 2025

In this PR, I made the field name text in the schema editor field row clickable so that the cursor in the Monaco editor jumps to the line defining that field. Originally, the requirement was to make the entire field row clickable. However, since there are other buttons, such as a pill-type button and a three-dot button, inside the field row, I made only the field name text clickable to avoid nested buttons. I'm open to any other approaches.

Here’s a revised version of your sentence for better clarity and grammar:

Note: These updates won't work in CardDef. There is a bug in schema-analysis-plugin when parsing possibleFields for CardDef. I'll submit the fix in a separate PR.

Screen.Recording.2025-03-06.at.15.04.44.mov

Copy link

github-actions bot commented Mar 6, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   24m 54s ⏱️ +42s
796 tests +3  794 ✔️ +3  2 💤 ±0  0 ±0 
801 runs  +3  799 ✔️ +3  2 💤 ±0  0 ±0 

Results for commit d8f57f2. ± Comparison against base commit 1e9a06f.

♻️ This comment has been updated with latest results.

@FadhlanR FadhlanR requested a review from a team March 6, 2025 12:47
@FadhlanR FadhlanR marked this pull request as ready for review March 6, 2025 12:47
@tintinthong
Copy link
Contributor

tintinthong commented Mar 6, 2025

Screenshot 2025-03-06 at 21 50 37

Is there a way to set a cursor straight to the fieldName.

Copy link
Contributor

@tintinthong tintinthong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and the behavior seems pretty solid. Just nitpick about the cursor position (just seems weird position bcos the user will not type there straight away)

@tintinthong tintinthong requested a review from a team March 6, 2025 14:08
@FadhlanR FadhlanR merged commit bbcdef3 into main Mar 7, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants