-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make schema editor field row clickable #2247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e line defining that field
tintinthong
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested and the behavior seems pretty solid. Just nitpick about the cursor position (just seems weird position bcos the user will not type there straight away)
lukemelia
approved these changes
Mar 6, 2025
Co-authored-by: Luke Melia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I made the field name text in the schema editor field row clickable so that the cursor in the Monaco editor jumps to the line defining that field. Originally, the requirement was to make the entire field row clickable. However, since there are other buttons, such as a pill-type button and a three-dot button, inside the field row, I made only the field name text clickable to avoid nested buttons. I'm open to any other approaches.
Here’s a revised version of your sentence for better clarity and grammar:
Note: These updates won't work in
CardDef
. There is a bug inschema-analysis-plugin
when parsingpossibleFields
forCardDef
. I'll submit the fix in a separate PR.Screen.Recording.2025-03-06.at.15.04.44.mov