-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GeCo to Carla #154
base: main
Are you sure you want to change the base?
Adding GeCo to Carla #154
Conversation
Hi, thanks for submitting your PR. Some comments on first glance:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GibbsG thanks for submitting your first PR! A great addition to also have some Julia based models included. See few comments below
Hi @JohanvandenHeuvel thanks for reviewing it. I think most of them are addressed. The packages for GeCo itself are located at this file: carla/recourse_methods/catalog/geco/library/GeCo.jl/Manifest.toml. To run Julia in Python, we need one additional package from here https://pyjulia.readthedocs.io/en/latest/installation.html. |
Hi,
This PR is for adding GeCo, a counterfactual model, to Carla Benchmark. I also added the test in test/test_cfmodel.py and also updated the experiments to include GeCo.
Please have a look!
Thanks!
Gibbs