#197 Remove axios package #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 13452631437Details
💛 - Coveralls |
3 tasks
nevendyulgerov
added
staking
nevendyulgerov
force-pushed
the
chore/197-remove-axios-package
branch
from
a4afd4b to
d860aea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I removed the
axiospackage and refactored the places in the app where this library was utilised. In its place I used the nativefetchapi.In terms of compatibility,
fetchis available in all major browsers for multiple years so I don't think that this change will cause any regressions for users on "older" browsers.The only browser that doesn't support fetch is IE11 and that browser is not supported by Next.js either - https://nextjs.org/docs/architecture/supported-browsers.