Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composer): make composer PHP files v8.1 compatible #57

Closed
wants to merge 1 commit into from

Conversation

M-arcus
Copy link
Contributor

@M-arcus M-arcus commented Jan 27, 2025

This pull request includes a small change to the composer/MagoPlugin.php file. The change removes the readonly keyword from the MagoPlugin class definition and adjusts the PACKAGE_NAME constant to include a docblock for type annotation.

  • composer/MagoPlugin.php: Removed the readonly keyword from the MagoPlugin class and added a docblock for the PACKAGE_NAME constant.

The following rector config was used:

<?php

declare(strict_types=1);

use Rector\Config\RectorConfig;

return RectorConfig::configure()
    ->withPaths([__DIR__ . '/composer'])
    ->withBootstrapFiles([__DIR__ . '/vendor/autoload.php'])
    ->withDowngradeSets(php81: true);

@azjezz
Copy link
Member

azjezz commented Jan 27, 2025

@veewee beat you to it 😅 thank you

@azjezz azjezz closed this Jan 27, 2025
@azjezz azjezz added Priority: High After critical issues are fixed, handle these before any further issues. Type: Bug An issue causing unintended or problematic behavior. Status: Closed This issue is closed and no more work is planned. Subject: Composer An issue or PR related to the composer plugin. labels Jan 27, 2025
@M-arcus M-arcus deleted the patch-2 branch January 27, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High After critical issues are fixed, handle these before any further issues. Status: Closed This issue is closed and no more work is planned. Subject: Composer An issue or PR related to the composer plugin. Type: Bug An issue causing unintended or problematic behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants