Skip to content

Commit

Permalink
issues/263 - Tidy up for review
Browse files Browse the repository at this point in the history
  • Loading branch information
meywood committed Apr 15, 2024
1 parent 8e15ee4 commit daa747a
Show file tree
Hide file tree
Showing 8 changed files with 5 additions and 9 deletions.
4 changes: 2 additions & 2 deletions src/main/java/com/syntifi/crypto/key/ASN1Identifiers.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* @since 0.1.0
*/
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public class ASN1Identifiers{
public class ASN1Identifiers {

public static final ASN1ObjectIdentifier Secp256k1OIDCurve = new ASN1ObjectIdentifier("1.3.132.0.10");
public static final ASN1ObjectIdentifier Secp256k1OIDkey = new ASN1ObjectIdentifier("1.2.840.10045.2.1");
Expand All @@ -22,4 +22,4 @@ public class ASN1Identifiers{
public static final String PUBLIC_KEY_DER_HEADER = "PUBLIC KEY";
public static final String PRIVATE_KEY_DER_HEADER = "PRIVATE KEY";
public static final String EC_PRIVATE_KEY_DER_HEADER = "EC PRIVATE KEY";
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ public void loadPublicKey(final byte[] publicKey) throws IOException {
} else {
throw new IOException();
}

}

@Override
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/syntifi/crypto/key/encdec/Base58.java
Original file line number Diff line number Diff line change
Expand Up @@ -160,4 +160,4 @@ private static byte divmod(byte[] number, int firstDigit, int base, int divisor)
}
return (byte) remainder;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ private boolean[] bytesToBits(byte[] data) {
return bits;
}


/**
* Gets the word list this code uses.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,4 @@ public MnemonicWordException(String badWord) {
this.badWord = badWord;
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,4 @@ void cep57houldMatchUpperCaseAddress() {
assertEquals("51DA5aE5C39880Bfe4f94B0898332d1BD37e647F72f79Cf23475df1Bb1f85bEA",
MixedCaseChecksum.checksumEncodeCEP57("51da5ae5c39880bfe4f94b0898332d1bd37e647f72f79cf23475df1bb1f85bea"));
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public class HierarchicalDeterministicKeyTest {
private static final Logger LOGGER = LoggerFactory.getLogger(HierarchicalDeterministicKey.class);


@Test
void getMasterKeyFromSeed_seed_should_match() {
byte[] init = "ed25519 seed".getBytes(StandardCharsets.UTF_8);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ void bs58() {
assertEquals(expected, Base58.encode(bytes));
assertArrayEquals(Base58.decode(expected), bytes);
}
}
}

0 comments on commit daa747a

Please sign in to comment.