-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update and simplify script #326
base: main
Are you sure you want to change the base?
Conversation
The only difference in build output now is that the lines of trailing newlines and more importantly the .css files are in just |
I don't think you want to change the |
Ah that's why, the GH Pages action deploys the dist directory, and the dist in the dist is needed for the URLs yeah. Argh... |
My other question is why do we have: discord/src/catppuccin-frappe.theme.scss Lines 1 to 9 in 80c0fcb
Those comments are just stripped out when we compress the files in build... |
I guess we can remove them or update the fields later, outside of the scope of this PR. |
On my hardware, this script completes 2-3 seconds slower than the script currently in use. it also removes the |
Hi! Sorry for the delayed response, I've been hard at work resolving that perf issue... 🕵️ I've managed to get the For comparison, the previous release script ran for ~2.055 s, and the previous build script (no accents generated) ran just a teeny bit quicker than this PR's release script at 610.7 ms. The only difference remaining would be the |
{ | ||
style: "compressed", | ||
loadPaths: ["node_modules/", "src/"], | ||
silenceDeprecations: ["color-functions"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed since we are currently using deprecated Sass functions to adjust lightness of colors.
Deprecation Warning: lighten() is deprecated. Suggestions:
color.scale($color, $lightness: 100%)
color.adjust($color, $lightness: 35%)
More info: https://sass-lang.com/d/color-functions
╷
9 │ --brand-experiment-230: #{lighten($brand, math.div(70%, 2))};
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
../../../../src/components/_variables.scss 9:29 @import
_theme.scss 1:9 @import
- 16:9 root stylesheet
Any update on this? Happy to try to resolve these conflicts but if this isn't going to be reviewed in the near future I don't want to waste my time. |
Updates the script to use the more modern web ESM syntax (as opposed to the old Node.js CJS syntax). I've also simplified the script to use Catppuccin's npm package - which is already installed and used in the SASS files to import the colors, only updated the version of it - and use the SASS API for compilation instead of using the CLI as an npm script. I did some updates to the package.json as well (cleaned up the scripts, updated metadata).