-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(treesitter): add styles.miscs to disable hardcoded italics #659
Conversation
Set everything to `O.styles.conditionals or { "italic" }`, so, by default, the various settings are still italic. In other words, this is not a breaking change.
Catppuccin compiles your configuration to simple colors, it helps to reduce start up time. |
["@module"] = { fg = C.lavender, style = { "italic" } }, -- For identifiers referring to modules and namespaces. | ||
-- This is difficult to avoid hardcoding, as there is no user option for this (yet). | ||
-- For now, binding to `conditionals` because it is italic by default. | ||
["@module"] = { fg = C.lavender, style = O.styles.conditionals or { "italic" } }, -- For identifiers referring to modules and namespaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a conditional though?. You can always just style = {}
in userconfig or is it not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This precisely is the problem; the user’s config does not override this setting. That’s what I changed, by binding the setting for @module
to the users setting for conditionals (which, by default, is also italic). This way the user can change if modules are italic or not, while the default of italic is still preserved.
Hello! Sorry for taking so long to reply, I’ve been traveling. |
You can now do require("catppuccin").setup { styles = { miscs = {} } } To disable the remaining hardcoded styles |
Set everything to
O.styles.conditionals or { "italic" }
, so, by default, the various settings are still italic. In other words, this is not a breaking change.🎉 First off, thanks for taking the time to contribute! 🎉
Here are some guidelines:
rules for explicit and meaningful commit messages.
About pull requests
on Github's docs.
Here are some tips:
vim.g.catppuccin_debug = true
to get live config re-loading