feat!: rebalance colors, adhere to style guide & overhaul docs #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdbe
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Ignore this issue on my side.
The default (just running the plugin) and config 3 break with these changes.
- Default
- Config 3
Example config 2 is still broken with these changes, this should be fixed before releasing 2.0.
The example configs should also contain set -g status-right-length 100 since many people will just copy it an make an issue that it doesn't work.
I am unable to replicate the color issues using alacritty on macos |
I found the issue, it's on my side I loaded the main branch and then switched to this PR to see the diff, without switching it's gone. |
kjnsn
force-pushed
the
v2
branch
4 times, most recently
from
70961f3
to
5f37563
Compare
Option names have been changed to be more intuitive and more closely follow the tmux naming conventions. Renamed: @catppuccin_window_current_background -> @catppuccin_window_current_number_color @catppuccin_window_current_color -> @catppuccin_window_current_text_color @catppuccin_window_default_background -> @catppuccin_window_number_color @catppuccin_window_default_color -> @catppuccin_window_text_color Removed: @catppuccin_window_default_fill, @catppuccin_window_current_fill Just set the number and text colors.
docs: change the stack style for the preview, add flavor previews
docs: update links in the getting started guide
docs: restructure the docs folder
sgoudham
requested changes
Oct 19, 2024
sgoudham
requested changes
Oct 19, 2024
sgoudham
approved these changes
Oct 19, 2024
sgoudham
changed the title
pauldthomson
pushed a commit
to pauldthomson/tmux
that referenced
this pull request
Nov 14, 2024
…uccin#372) Option names have been changed to be more intuitive and more closely follow the tmux naming conventions. Renamed: @catppuccin_window_current_background -> @catppuccin_window_current_number_color @catppuccin_window_current_color -> @catppuccin_window_current_text_color @catppuccin_window_default_background -> @catppuccin_window_number_color @catppuccin_window_default_color -> @catppuccin_window_text_color Removed: @catppuccin_window_default_fill, @catppuccin_window_current_fill Just set the number and text colors. Co-authored-by: Hammy <[email protected]> feat!: rebalance the colors used, and follow the styleguide fix(tests): add tests for window styling refactor!: change how windows are styled feat: rebalance the status module colors for cpu and battery docs: update the preview images docs: change the stack style for the preview, add flavor previews docs: update readme for v2 changes docs: use a column layout for the preview docs: add an example of a ram custom module docs: use markdownlint to check README.md docs: add a getting started guide docs: update links in the getting started guide docs: move the status line docs to the docs dir docs: add basic demo using vhs docs: add config reference docs: move more docs into ./docs/ docs: restructure the docs folder docs: add design explanation docs: add the version tag to the manual install instructions docs: fill out the design philosophy chore: update issue templates and contributing.md docs: tidy up docs and add an updated structure image docs: add instructions for gitmux docs: add a background to the structure image docs(CONTRIBUTING.md): add missing `[` feat!: change how status modules are styled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.