Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session status icon bg color change by client_prefix #394

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

unisons
Copy link
Contributor

@unisons unisons commented Oct 21, 2024

The bg color of icon is always green.
I think the expands should be done later. There might be more cases.
This bug is observed on v2 but not v1.0.3.

@kjnsn
Copy link
Collaborator

kjnsn commented Oct 21, 2024

Thanks so much!

Also why on earth do we change the color of the session when the prefix key is pressed, somehow I missed this.

@kjnsn kjnsn merged commit 8855667 into catppuccin:main Oct 21, 2024
2 checks passed
@unisons unisons deleted the patch-2 branch October 21, 2024 11:37
@89iuv
Copy link
Collaborator

89iuv commented Oct 21, 2024

Thanks so much!

Also why on earth do we change the color of the session when the prefix key is pressed, somehow I missed this.

I really liked this feature.
It is an indicator that the tmux prefix has been triggered and any other input will be part of a tmux shortcut.

@kjnsn
Copy link
Collaborator

kjnsn commented Oct 21, 2024

Fair enough, but what does it have to do with the session name?

@89iuv
Copy link
Collaborator

89iuv commented Oct 21, 2024

Fair enough, but what does it have to do with the session name?

It should not have anything to do with the session name.
I think the logic brakes with some themes.

I am using it like this:
image
image

It is just a small indicator that the tmux prefix has been pressed.
It was here from the begging of the theme and i find it usefull.

pauldthomson pushed a commit to pauldthomson/tmux that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants