Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pinterest): misc #1581

Open
wants to merge 76 commits into
base: main
Choose a base branch
from
Open

fix(pinterest): misc #1581

wants to merge 76 commits into from

Conversation

nuexq
Copy link
Contributor

@nuexq nuexq commented Jan 16, 2025

🔧 What does this fix? 🔧

add multiple messing variables like --color-background-box-info-weak, --color-background-tabs-base...

  • adding --color-background-box-info-weak variable
  • adding --color-text-formfield-default variable
  • adding --color-background-tabs-(base/hover) variables
  • edit --color-background-box-light to match bg color
  • remove the @text style for pin hover icons (doesn't match there bg)
  • change pin hover icons bg to match theme
  • adding switch background and borders variables
  • adding checkbox background and borders variables
  • adding --color-background-button-white-(default/hover) variables
  • new input UI fix
  • new nav icons fix

🗒 Checklist 🗒

@github-actions github-actions bot added the pinterest Pinterest label Jan 16, 2025
@uncenter uncenter changed the title fix(Pinterest): adding multiple messing variables + fixing pin hover icon colors fix(pinterest): variables & pin hover icon Jan 16, 2025
@uncenter uncenter marked this pull request as draft January 17, 2025 17:48
@nuexq nuexq changed the title fix(pinterest): variables & pin hover icon fix(pinterest): multiple fixes Jan 18, 2025
@nuexq
Copy link
Contributor Author

nuexq commented Feb 11, 2025

the new UI is totally fixed now.

Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run deno lint:fix. Otherwise LGTM

@nuexq
Copy link
Contributor Author

nuexq commented Feb 15, 2025

I've run deno lint:fix but the problem of svg not optimized still, I've tryed optimize it with svgo npx svgo input.svg -o output.svg --multipass but still get the same lint error.

@uncenter
Copy link
Member

I've run deno lint:fix but the problem of svg not optimized still, I've tryed optimize it with svgo npx svgo input.svg -o output.svg --multipass but still get the same lint error.

deno task lint runs the optimizer on the SVG, and compares the output to what is there. If there is no difference, it is fully optimized. Running deno task lint:fix writes the optimized output in place of what was there, by definition fixing the optimization problem.

@nuexq
Copy link
Contributor Author

nuexq commented Feb 15, 2025

@uncenter Yeah, this might be a stupid question, but how do I clone the repository with the user styles so I can run deno task lint:fix? When I clone the repo, the scripts and styles directories don’t get cloned. I tried running the command in the GitHub workspace, but it didn’t change anything. so what's the currect way to do it ?

@uncenter
Copy link
Member

What command are you running to clone the repository?

@nuexq
Copy link
Contributor Author

nuexq commented Feb 15, 2025

What command are you running to clone the repository?

git clone https://github.com/catppuccin/userstyles.git or git clone [email protected]:nuexq/catppuccin-userstyles.git both doesn't clone everything

@uncenter
Copy link
Member

That command will give you the styles and scripts directories, I'm not sure where you are looking in your editor but they will definitely be there. Anyways, you'll need to clone your fork of the repository to push changes.

git clone https://github.com/nuexq/catppuccin-userstyles
cd catppuccin-userstyles
git checkout pinterest

@uncenter
Copy link
Member

What command are you running to clone the repository?

git clone https://github.com/catppuccin/userstyles.git or git clone [email protected]:nuexq/catppuccin-userstyles.git both doesn't clone everything

cd into the cloned repository and run ls. It is highly improbable that the clone is not cloning those directories at all.

@nuexq
Copy link
Contributor Author

nuexq commented Feb 15, 2025

this is what it cloned with git clone https://github.com/catppuccin/userstyles.git
image

@uncenter
Copy link
Member

Can you share what the git config --list --show-origin command gives you?

@nuexq
Copy link
Contributor Author

nuexq commented Feb 15, 2025

Can you share what the git config --list --show-origin command gives you?

image

I did not counter this problem on a repo before.

@nuexq
Copy link
Contributor Author

nuexq commented Feb 16, 2025

I've used git-lfs and it cloned correctly.

@nuexq
Copy link
Contributor Author

nuexq commented Feb 16, 2025

@uncenter idk why but the test passes without changing anything.

@uncenter
Copy link
Member

@uncenter idk why but the test passes without changing anything.

I pushed a commit yesterday fixing it at the start of our conversation.

@nuexq
Copy link
Contributor Author

nuexq commented Feb 16, 2025

I think it's ready to merge, you have any changes?

isabelroses
isabelroses previously approved these changes Feb 17, 2025
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nuexq
Copy link
Contributor Author

nuexq commented Feb 19, 2025

done requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinterest Pinterest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants