-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pinterest): misc #1581
base: main
Are you sure you want to change the base?
fix(pinterest): misc #1581
Conversation
light color icon begin white in latte theme
…riables i just invert(1) and did difference mix-blend-mode that's what best I can do to make it visible since the icon is actually a background-image of an svg so I can't change it's color
the new UI is totally fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you run deno lint:fix
. Otherwise LGTM
I've run deno lint:fix but the problem of svg not optimized still, I've tryed optimize it with svgo |
|
@uncenter Yeah, this might be a stupid question, but how do I clone the repository with the user styles so I can run |
What command are you running to clone the repository? |
|
That command will give you the styles and scripts directories, I'm not sure where you are looking in your editor but they will definitely be there. Anyways, you'll need to clone your fork of the repository to push changes.
|
|
Can you share what the |
I've used |
@uncenter idk why but the test passes without changing anything. |
I pushed a commit yesterday fixing it at the start of our conversation. |
I think it's ready to merge, you have any changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
done requested changes. |
🔧 What does this fix? 🔧
add multiple messing variables like
--color-background-box-info-weak
,--color-background-tabs-base
...--color-background-box-info-weak
variable--color-text-formfield-default
variable--color-background-tabs-(base/hover)
variables--color-background-box-light
to match bg color@text
style for pin hover icons (doesn't match there bg)--color-background-button-white-(default/hover)
variables🗒 Checklist 🗒