Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow more than one job per instance #1184

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

N8ND
Copy link
Contributor

@N8ND N8ND commented Sep 6, 2024

Description

We want to make the runners_capacity_per_instance variable since we want to be able to run more than 1 job on 1 EC2 instance.

Migrations required

No.

Verification

Using docker_autoscaler, set the capacity_per_instance from 1 to 4 in /etc/gitlab-runner/config.toml, exec gitlab-runner restart , and verify that only 1 instance is created when running a pipeline with 4 concurrent jobs. Also verified the reported instance in the 4 jobs is the same.

N8ND and others added 3 commits September 6, 2024 10:51
runners_capacity_per_instance
runner_worker_docker_autoscaler
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Hey @N8ND! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@N8ND N8ND changed the title Feat/runners capacity per instance feat/runners capacity per instance Sep 6, 2024
@N8ND N8ND changed the title feat/runners capacity per instance feat: runners capacity per instance Sep 6, 2024
@kayman-mk
Copy link
Collaborator

Was looking for a while for this feature. Are you using the docker+autoscaler?

@N8ND
Copy link
Contributor Author

N8ND commented Sep 6, 2024

Was looking for a while for this feature. Are you using the docker+autoscaler?

Yes indeed, using docker+autoscaler.

@kayman-mk kayman-mk changed the title feat: runners capacity per instance feat: allow more than one job per instance Sep 9, 2024
Copy link
Collaborator

@kayman-mk kayman-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature.

@kayman-mk kayman-mk merged commit f7f2ea2 into cattle-ops:main Sep 9, 2024
22 checks passed
kayman-mk pushed a commit that referenced this pull request Sep 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.14.0](7.13.1...7.14.0)
(2024-09-17)


### Features

* allow more than one job per instance
([#1184](#1184))
([f7f2ea2](f7f2ea2))


### Bug Fixes

* autoscaler asg subnets and add possibility to enable metrics for asg
([#1182](#1182))
([3335b81](3335b81))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants