Avoid retrieving duplicate documents by ID #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/dicts/foo/restful/ids?ids=bar&ids=bar&ids=bar&ids=bar
returns the same document four times. I am aware this doesn't mean the end of the world, but maybe something close.This just ensures the
ids
list that came from the controller and is passed toelasticsearch-dsl
'sdoc.mget
method contains only unique IDs by doing a quicklist(set(ids))
.Technically,
set(ids)
would be enough, as elasticsearch-dsl just loops over the elements of any sequence, but thedocs
argument ofmget
is documented as a "list ofid
s of the documents to be retrieved or a list of document specifications" (although the type hint fordocs
isList[Dict[str, Any]]
, so I guess they're just being sloppy with their docs and/or type hints anyway).