PLUGIN-296 Add integration test for SpannerSource getSchema from import Query #1084

ardian4 · 2021-01-05T15:30:19Z

JiraTicket: https://cdap.atlassian.net/browse/PLUGIN-296

google-cla · 2021-01-05T15:30:25Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

CuriousVini · 2021-01-06T05:06:54Z

integration-test-remote/src/test/java/io/cdap/cdap/app/etl/gcp/GoogleCloudSpannerTest.java

@@ -53,7 +53,6 @@
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.BeforeClass;
-import org.junit.Ignore;


Is this change intentional?

code style removes this line automatically.

CuriousVini · 2021-01-06T05:10:43Z

integration-test-remote/src/test/java/io/cdap/cdap/app/etl/gcp/GoogleCloudSpannerTest.java

+      .build();
+
+    String applicationName = SPANNER_PLUGIN_NAME + "-testReadWithImportQuery";
+    String nonExistentSinkTableName = "nonexistent_" + UUID.randomUUID().toString().replaceAll("-", "_");


should delete this table at the end of the test

CuriousVini · 2021-01-06T05:14:14Z

integration-test-remote/src/test/java/io/cdap/cdap/app/etl/gcp/GoogleCloudSpannerTest.java

+      .put("instance", "${instance}")
+      .put("database", "${database}")
+      .put("table", "${srcTable}")
+      .put("importQuery","Select ID, STRING_COL as StringCol, BOOL_COL from " + SOURCE_TABLE_NAME)


should include query with complex types as well - timestamp, array, bytes, date etc

would be good to add import query as a macro as well.

should include query with complex types as well - timestamp, array, bytes, date etc

we added complex types - left some out fields out as test for getting only selected fields from table instead all of them.

google-cla · 2021-01-06T15:24:07Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

CuriousVini

LGTM 👍🏼
Please squash the commits

CuriousVini · 2021-01-08T06:46:25Z

integration-test-remote/src/test/java/io/cdap/cdap/app/etl/gcp/GoogleCloudSpannerTest.java

@@ -53,7 +53,6 @@
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.BeforeClass;
-import org.junit.Ignore;


…rtQuery

google-cla · 2021-01-08T09:31:07Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

ardian4 · 2021-01-08T09:31:37Z

LGTM 👍🏼
Please squash the commits

Done

ardian4 mentioned this pull request Jan 5, 2021

updated/PLUGIN-296 data-integrations/google-cloud#457

Merged

CuriousVini reviewed Jan 6, 2021

View reviewed changes

CuriousVini approved these changes Jan 8, 2021

View reviewed changes

PLUGIN-296 Add integration test for SpannerSource getSchema from Impo…

a604f3e

…rtQuery

ardian4 force-pushed the feature/PLUGIN-296 branch from fa3c0e2 to a604f3e Compare January 8, 2021 09:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PLUGIN-296 Add integration test for SpannerSource getSchema from import Query #1084

PLUGIN-296 Add integration test for SpannerSource getSchema from import Query #1084

ardian4 commented Jan 5, 2021

google-cla bot commented Jan 5, 2021

CuriousVini Jan 6, 2021

ardian4 Jan 6, 2021

CuriousVini Jan 8, 2021

CuriousVini Jan 6, 2021

CuriousVini Jan 6, 2021

CuriousVini Jan 6, 2021

ardian4 Jan 6, 2021

google-cla bot commented Jan 6, 2021

CuriousVini left a comment

CuriousVini Jan 8, 2021

google-cla bot commented Jan 8, 2021

ardian4 commented Jan 8, 2021

PLUGIN-296 Add integration test for SpannerSource getSchema from import Query #1084

Are you sure you want to change the base?

PLUGIN-296 Add integration test for SpannerSource getSchema from import Query #1084

Conversation

ardian4 commented Jan 5, 2021

google-cla bot commented Jan 5, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-cla bot commented Jan 6, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

CuriousVini left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-cla bot commented Jan 8, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

ardian4 commented Jan 8, 2021