PR #15800 #2249
vsethi09codeql
on: dynamic
Matrix: analyze
Annotations
2 errors and 67 warnings
|
NoSqlDefaultStoreTest.testLogProgramRunHistory:
NoSqlDefaultStoreTest#L1
expected:<RunRecordDetail{programRunId=program_run:account1.application1.-SNAPSHOT.workflow.wf1.f7c1d8b8-d8ae-11ef-a5d9-b29097a3acaf, startTs=1737543146, runTs=null, stopTs=1737543147, suspendTs=null, resumeTs=null, stoppingTs=null, terminateTs=null, status=FAILED, twillrunid=null, systemArgs={}, properties={runtimeArgs={}}, cluster=ProgramRunCluster{status=PROVISIONED, end=null, numNodes=0}, profile=profile:system.native, peerName=null, sourceId=0000000000000020000000000000000000000000, artifactId=ArtifactId{name='testArtifact', version=1.0, scope='USER'}, principal=null, flowcontrolstatus=null}> but was:<RunRecordDetail{programRunId=program_run:account1.application1.-SNAPSHOT.workflow.wf1.f7c1d8b8-d8ae-11ef-a5d9-b29097a3acaf, startTs=1737543146, runTs=null, stopTs=1737543147, suspendTs=null, resumeTs=null, stoppingTs=null, terminateTs=null, status=FAILED, twillrunid=null, systemArgs={system.profile.name=SYSTEM:native}, properties={runtimeArgs={}}, cluster=ProgramRunCluster{status=PROVISIONED, end=null, numNodes=0}, profile=profile:system.native, peerName=null, sourceId=0000000000000020000000000000000000000000, artifactId=ArtifactId{name='testArtifact', version=1.0, scope='USER'}, principal=null, flowcontrolstatus=launching}>
|
|
SqlDefaultStoreTest.testLogProgramRunHistory:
SqlDefaultStoreTest#L1
expected:<RunRecordDetail{programRunId=program_run:account1.application1.-SNAPSHOT.workflow.wf1.ea71cbc8-d8ae-11ef-b049-b29097a3acaf, startTs=1737543124, runTs=null, stopTs=1737543125, suspendTs=null, resumeTs=null, stoppingTs=null, terminateTs=null, status=FAILED, twillrunid=null, systemArgs={}, properties={runtimeArgs={}}, cluster=ProgramRunCluster{status=PROVISIONED, end=null, numNodes=0}, profile=profile:system.native, peerName=null, sourceId=0000000000000020000000000000000000000000, artifactId=ArtifactId{name='testArtifact', version=1.0, scope='USER'}, principal=null, flowcontrolstatus=null}> but was:<RunRecordDetail{programRunId=program_run:account1.application1.-SNAPSHOT.workflow.wf1.ea71cbc8-d8ae-11ef-b049-b29097a3acaf, startTs=1737543124, runTs=null, stopTs=1737543125, suspendTs=null, resumeTs=null, stoppingTs=null, terminateTs=null, status=FAILED, twillrunid=null, systemArgs={system.profile.name=SYSTEM:native}, properties={runtimeArgs={}}, cluster=ProgramRunCluster{status=PROVISIONED, end=null, numNodes=0}, profile=profile:system.native, peerName=null, sourceId=0000000000000020000000000000000000000000, artifactId=ArtifactId{name='testArtifact', version=1.0, scope='USER'}, principal=null, flowcontrolstatus=launching}>
|
|
Analyze (ruby)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Analyze (javascript)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Analyze (python)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventSubscriber.java#L24
Wrong lexicographical order for 'io.cdap.cdap.internal.app.services.FlowControlService' import. Should be before 'io.cdap.cdap.internal.app.services.ProgramLifecycleService'.
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/services/ProgramNotificationSubscriberService.java#L98
First sentence of Javadoc is missing an ending period.
|
|
com.puppycrawl.tools.checkstyle.checks.design.OneTopLevelClassCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/services/ProgramNotificationSubscriberService.java#L247
Top-level class ProgramNotificationSingleTopicSubscriberService has to reside in its own source file.
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/services/ProgramLifecycleService.java#L1548
Abbreviation in name 'appCDAPVersion' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.sizes.FileLengthCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1
File length is 3,137 lines (max allowed is 3,000).
|
|
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L104
Empty line should be followed by <p> tag on the next line.
|
|
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L108
Empty line should be followed by <p> tag on the next line.
|
|
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L111
Empty line should be followed by <p> tag on the next line.
|
|
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L113
Empty line should be followed by <p> tag on the next line.
|
|
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L116
Empty line should be followed by <p> tag on the next line.
|
|
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L118
Empty line should be followed by <p> tag on the next line.
|
|
|
|
|
|
|
|
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1329
Distance between variable 'meta' declaration and its first usage is 6, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
|
|
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1784
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,692'.
|
|
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1866
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,823'.
|
|
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1881
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,758'.
|
|
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1921
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,866'.
|
|
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1955
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,668'.
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L2020
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,955'.
|
|
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L2315
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,983'.
|
|
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L2329
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '2,020'.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L2554
First sentence of Javadoc is missing an ending period.
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L2640
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '736'.
|
|
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L2850
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '2,285'.
|
|
com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/app/guice/AppFabricServiceRuntimeModule.java#L121
Wrong lexicographical order for 'io.cdap.cdap.internal.app.services.FlowControlService' import. Should be before 'io.cdap.cdap.internal.app.services.RunRecordCorrectorService'.
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/events/StartProgramEventSubscriberTest.java#L30
Wrong lexicographical order for 'io.cdap.cdap.internal.app.services.FlowControlService' import. Should be before 'io.cdap.cdap.internal.app.services.ProgramLifecycleService'.
|
|
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/ProgramNotificationSubscriberServiceTest.java#L150
Distance between variable 'sparkId2' declaration and its first usage is 8, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
|
|
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/store/AppMetadataStoreTest.java#L659
Distance between variable 'activeRuns' declaration and its first usage is 10, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
|
|
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/store/AppMetadataStoreTest.java#L704
Distance between variable 'activeRuns' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
|
|
com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/store/AppMetadataStoreTest.java#L847
WhitespaceAround: ':' is not preceded with whitespace.
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/store/AppMetadataStoreTest.java#L1673
Abbreviation in name 'GSON' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.naming.LocalVariableNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/store/AppMetadataStoreTest.java#L1673
Local variable name 'GSON' must match pattern '^[a-z]([a-zA-Z0-9]+)?$'.
|
|
|
|
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck:
cdap-common/src/main/java/io/cdap/cdap/internal/app/store/RunRecordDetail.java#L16
'package' should be separated from previous line.
|
|
com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck:
cdap-common/src/main/java/io/cdap/cdap/internal/app/store/RunRecordDetail.java#L29
Unused import - io.cdap.cdap.runtime.spi.provisioner.Cluster.
|
|
|
|
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-common/src/main/java/io/cdap/cdap/internal/app/store/RunRecordDetail.java#L247
Abbreviation in name 'ABuilder' must contain no more than '1' consecutive capital letters.
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck:
cdap-common/src/main/java/io/cdap/cdap/internal/app/store/RunRecordDetail.java#L304
'METHOD_DEF' should be separated from previous line.
|
|
|
|
|
|
|
|
|