Skip to content

PR #15800

PR #15800 #2291

Triggered via dynamic January 24, 2025 12:46
Status Success
Total duration 1m 38s
Artifacts

codeql

on: dynamic
Matrix: analyze
Fit to window
Zoom out
Zoom in

Annotations

64 warnings
com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventSubscriber.java#L24
Wrong lexicographical order for 'io.cdap.cdap.internal.app.services.FlowControlService' import. Should be before 'io.cdap.cdap.internal.app.services.ProgramLifecycleService'.
com.puppycrawl.tools.checkstyle.checks.design.OneTopLevelClassCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/services/ProgramNotificationSubscriberService.java#L247
Top-level class ProgramNotificationSingleTopicSubscriberService has to reside in its own source file.
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1329
Distance between variable 'meta' declaration and its first usage is 6, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1787
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,695'.
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1869
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,826'.
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1884
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,761'.
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1924
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,869'.
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L1958
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,671'.
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L2023
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,958'.
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L2318
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,986'.
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L2332
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '2,023'.
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L2643
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '736'.
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/AppMetadataStore.java#L2853
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '2,288'.
com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/app/guice/AppFabricServiceRuntimeModule.java#L121
Wrong lexicographical order for 'io.cdap.cdap.internal.app.services.FlowControlService' import. Should be before 'io.cdap.cdap.internal.app.services.RunRecordCorrectorService'.
com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/events/StartProgramEventSubscriberTest.java#L30
Wrong lexicographical order for 'io.cdap.cdap.internal.app.services.FlowControlService' import. Should be before 'io.cdap.cdap.internal.app.services.ProgramLifecycleService'.
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/ProgramNotificationSubscriberServiceTest.java#L150
Distance between variable 'sparkId2' declaration and its first usage is 8, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/store/AppMetadataStoreTest.java#L659
Distance between variable 'activeRuns' declaration and its first usage is 10, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/store/AppMetadataStoreTest.java#L704
Distance between variable 'activeRuns' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck: cdap-common/src/main/java/io/cdap/cdap/internal/app/store/RunRecordDetail.java#L247
Abbreviation in name 'ABuilder' must contain no more than '1' consecutive capital letters.