Skip to content

PR #15810 #2297

Sign in to view logs

PR #15810

PR #15810 #2297

Triggered via dynamic January 27, 2025 06:41
@ritwiksahaniritwiksahani
⁠ fa6696b
refs/pull/15810/head
Status Success
Total duration 1m 46s
Artifacts –

codeql

on: dynamic
Matrix: analyze
Fit to window
Zoom out
Zoom in

Annotations

1 error and 25 warnings
CoreSchedulerServiceTest.testRunScheduledJobs: CoreSchedulerServiceTest#L340
java.lang.NullPointerException at io.cdap.cdap.scheduler.CoreSchedulerServiceTest.testRunScheduledJobs(CoreSchedulerServiceTest.java:340)
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/trigger/TimeTrigger.java#L141
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '57'.
com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/trigger/ProgramStatusTrigger.java#L98
Missing a Javadoc comment.
com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/trigger/NotificationContext.java#L20
Unused import - io.cdap.cdap.common.conf.CConfiguration.
com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/trigger/NotificationContext.java#L21
Unused import - io.cdap.cdap.common.service.RetryStrategies.
com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/trigger/NotificationContext.java#L42
Missing a Javadoc comment.
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/queue/JobQueueTable.java#L65
Empty line should be followed by <p> tag on the next line.
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/queue/JobQueueTable.java#L71
Empty line should be followed by <p> tag on the next line.
com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocParagraphCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/queue/JobQueueTable.java#L78
Empty line should be followed by <p> tag on the next line.
com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/schedule/queue/JobQueueTable.java#L442
First sentence of Javadoc is missing an ending period.
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/workflow/BasicWorkflowToken.java#L255
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '227'.
com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/workflow/BasicWorkflowToken.java#L272
Missing a Javadoc comment.
com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/workflow/BasicWorkflowToken.java#L347
'+' should be on a new line.
com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/workflow/BasicWorkflowToken.java#L348
'+' should be on a new line.
com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/workflow/BasicWorkflowToken.java#L349
'+' should be on a new line.
com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/workflow/BasicWorkflowToken.java#L350
'+' should be on a new line.
com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/workflow/BasicWorkflowToken.java#L351
'+' should be on a new line.
com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/workflow/BasicWorkflowToken.java#L352
'+' should be on a new line.
com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/workflow/BasicWorkflowToken.java#L353
'+' should be on a new line.
com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/schedule/trigger/ProgramStatusTriggerTest.java#L1
File does not end with a newline.
com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/schedule/trigger/ProgramStatusTriggerTest.java#L29
Unused import - io.cdap.cdap.common.conf.CConfiguration.
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/runtime/schedule/trigger/ProgramStatusTriggerTest.java#L74
Distance between variable 'notificationList' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/AppWithMultipleSchedules.java#L103
'METHOD_DEF' should be separated from previous line.
com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/AppWithMultipleSchedules.java#L128
'METHOD_DEF' should be separated from previous line.
com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/AppWithMultipleSchedules.java#L160
'METHOD_DEF' should be separated from previous line.
com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/AppWithMultipleSchedules.java#L166
'METHOD_DEF' should be separated from previous line.