added a release pipeline #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rjtch <[email protected]>
rjtch
force-pushed
the
workflow_for_releases_#14
branch
from
94720aa to
27984a9
Compare
|
IMHO, we don't need cargo-dist as we provide a lib and not an executable binary. |
Yes you are wright i am working on it! |
Signed-off-by: rjtch <[email protected]>
Signed-off-by: rjtch <[email protected]>
davidB
requested changes
Feb 25, 2024
Signed-off-by: rjtch <[email protected]>
davidB
requested changes
Mar 2, 2024
|
@rjtch Please don't use the nightly toolchain for CI & linting, our target is stable. And it's better if version used by ci is aligned with what is defined into the project to allow developer to reproduce locally ci,... (building / linting against nightly is informative, optional and not a blocker). |
Signed-off-by: rjtch <[email protected]>
rjtch
force-pushed
the
workflow_for_releases_#14
branch
from
b5611c3 to
965cf4a
Compare
|
I didn't have the failure in the ci/tests. The issue is in the spec IMHO (URL field of type |
davidB
approved these changes
Mar 3, 2024
|
After the merge of this PR, I'll rebase PR #19, so CI should become green 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a release pipeline wip