Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on a websocket API for some time and just realized that browsers still don't support setting headers like Authorization (or anything else other than Sec-WebSocket-Protocol), which makes things a little bit more complicated.
So, now I'm wondering what would be the most straightforward and flexible way to allow for custom token extraction?
I was thinking that probably adding a new
token_extractor
field onAuthorizer
andAuthorizerBuilder
along with a method on the builder to allow passing an extractor function would be the easiest way to extend token extraction without touching theJwtSource
enum.Might be a good idea to skip setting the
token_extractor
entirely ifjwt_source
is passed, but not sure about that.Let me know what you think and if there's a better way to go about this.