Skip to content

Commit

Permalink
fix: testing timeout usage (#401)
Browse files Browse the repository at this point in the history
* chore: remove duplicate timeout definitions

The make test command was using the KNUU_TIMEOUT and -timeout variables.
I removed the -timeout flags as a default of 10m is sufficient.
We have a .env file that we can use for the KNUU_TIMEOUT so I removed it
from the command itself.

* fix: clean up ci test file

The merge_group trigger wasn't set so test won't be run on the merge
queue.
We were setting the KNUU_TIMEOUT specifically in the test, but this
wasn't being honored due to the reasons in the previous commit.

* chore: remove .env file and add go test timeout back
  • Loading branch information
MSevey authored May 31, 2024
1 parent 20f3ce9 commit 4364f4b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
6 changes: 0 additions & 6 deletions .env

This file was deleted.

2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,5 @@ vet:

## test: Run the testsuite
test: vet
KNUU_TIMEOUT=120m go test -v $(pkgs) -run $(run) -count=$(count) -timeout $(timeout)
go test -v $(pkgs) -run $(run) -count=$(count) -timeout $(timeout)
.PHONY: test

0 comments on commit 4364f4b

Please sign in to comment.