Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate image builder(s) #232

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

mojtaba-esk
Copy link
Contributor

This PR attempts to integrate the developed image builder which is based on kaniko.

The docker builder is also moved to the builder package.
A SetGitRepo method is added to an instance which builds and image from a git repo and assigns it to the instance.

@mojtaba-esk mojtaba-esk requested a review from a team January 19, 2024 11:45
@mojtaba-esk mojtaba-esk self-assigned this Jan 19, 2024
pkg/builder/docker/docker.go Fixed Show fixed Hide fixed
pkg/builder/docker/docker.go Fixed Show fixed Hide fixed
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

@mojtaba-esk mojtaba-esk merged commit 194e665 into main Jan 22, 2024
3 checks passed
@mojtaba-esk mojtaba-esk deleted the mojtaba/integrate-image-builder branch January 22, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants