Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update-geth.sh #304

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Fix update-geth.sh #304

merged 4 commits into from
Feb 4, 2025

Conversation

piersy
Copy link

@piersy piersy commented Feb 4, 2025

The script was not substituting the go.mod file and the Dockerfile since the regexes were not matching.

The regex for the Dockerfile contained @sha256: which perl was interpreting as a global symbol, in order to interpret it literally we needed to escape the @.

The regex for the go.mod file contained an extra space before the arrow go-ethereum .* =>, in a tidied go.mod file there is one space between the package name and the arrow =>.

Also adds failure output so that it's easier to debug where this is going wrong.

Fixes https://github.com/celo-org/celo-blockchain-planning/issues/891

The script was not substituting the go.mod file and the Dockerfile since the
regexes were not matching.

The regex for the Dockerfile contained '@sha256:' which perl was
interpreting as a global symbol, in order to interpret it literally we
needed to escape the '@'.

The regex for the go.mod file contained an extra space before the arrow
'go-ethereum .* => ', in a tidied go.mod file there is one space between
the package name and the arrow '=>'.

Also adds failure output so that it's easier to debug where this is
going wrong.
@piersy piersy requested review from ezdac and karlb February 4, 2025 13:37
Copy link

@karlb karlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'll use this much because

But it is an improvement, so let's merge it!

ops/celo/update-geth.sh Outdated Show resolved Hide resolved
@piersy piersy merged commit 2c712ae into celo10 Feb 4, 2025
54 of 56 checks passed
@piersy piersy deleted the piersy/fix-update-geth-script branch February 4, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants