Update release branch #306
Conversation
The script was not substituting the go.mod file and the Dockerfile since the regexes were not matching. The regex for the Dockerfile contained '@sha256:' which perl was interpreting as a global symbol, in order to interpret it literally we needed to escape the '@'. The regex for the go.mod file contained an extra space before the arrow 'go-ethereum .* => ', in a tidied go.mod file there is one space between the package name and the arrow '=>'. Also adds failure output so that it's easier to debug where this is going wrong. --------- Co-authored-by: Karl Bartel <[email protected]> Co-authored-by: Paul Lange <[email protected]>
The substitution \1 and the beginning of the image hash together created
\150 which perl interprets as the octal character code for h.
To prevent this we need to use the \${1} notation to reference captured
groups.
piersy
force-pushed
the
piersy/update-release-branch
branch
from
4444de3 to
de5edc2
Compare
|
Still some errors: |
piersy
force-pushed
the
piersy/update-release-branch
branch
from
de5edc2 to
ffba5ac
Compare
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an AI-detected potential code anomaly?AI has identified unusual behaviors that may pose a security risk. An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
| @@ -138,7 +138,7 @@ func testFees(t *testing.T, cfg e2esys.SystemConfig) { | |||
|
|
|||
| baseFeeRecipient := predeploys.BaseFeeVaultAddr | |||
| if sys.RollupConfig.IsCel2(sys.L2GenesisCfg.Timestamp) { | |||
| baseFeeRecipient = addresses.GetAddresses(cfg.L2ChainIDBig()).FeeHandler | |||
| baseFeeRecipient = addresses.FeeHandlerAddress | |||
There was a problem hiding this comment.
Why is this coming in? This looks like we're stepping back.
Updating the release branch with these fixes and the latest version of geth from the corresponding release branch (celo-release-v2.0) in op-geth.