Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for correct 'emotionally_laden' doc extension when creating emotion classifier #286

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix: check for correct 'emotionally_laden' doc extension when creating emotion classifier #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dacy/sentiment/wrapped_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def make_emotion_transformer(
doc_extension_prediction: str,
labels: List[str], # type: ignore
) -> SequenceClassificationTransformer:
if not Doc.has_extension("dacy/emotionally_laden"):
if not Doc.has_extension("emotionally_laden"):
warn(
"The 'emotion' component assumes the 'emotionally_laden' extension is set."
+ " To set it you can run nlp.add_pipe('dacy/emotionally_laden')",
Expand All @@ -162,7 +162,7 @@ def make_emotion_transformer(

# overwrite extension such that it return no emotion if the document does not have
# an emotion
if Doc.has_extension("dacy/emotionally_laden"):
if Doc.has_extension("emotionally_laden"):

def label_getter(doc) -> Optional[str]: # noqa: ANN001 # type: ignore
if doc._.emotionally_laden == "emotional":
Expand Down
2 changes: 2 additions & 0 deletions tests/test_sentiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@ def test_add_berttone_polarity():
def test_add_bertemotion_laden():
nlp = spacy.blank("da")
nlp.add_pipe("dacy/emotionally_laden")
nlp.add_pipe("dacy/emotion")
doc = nlp("Der er et træ i haven")
assert doc._.emotionally_laden == "no emotion"
assert doc._.emotion == "no emotion"


def test_add_bertemotion_emo():
Expand Down
Loading