add Unwrap method to allow to detect root cause error with errors.Is #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We realised that detecting certain types of errors does not work as expected because error types are missing
Unwrap
method required forerrors.Is
to work:This PR adds corresponding methods to error types in
errors.go
and a corresponding test (fails without Unwrap, but works with it in place). I suspect it may be not required for some types like ConfigError, but adding the method anyway for uniformity.Also changed a
--client_insecure
to--client.insecure
in the workflow as old flag no longer works with latest centrifuge (this leads to workflows failing).