Support emits the pong event to the client and improves code clarity #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed typos and inconsistencies in comments for better readability. - Replaced redundant expressions with simpler alternatives for clarity. - Added `pong` event handling for server-side communication.
|
Hello @ali-master - thanks! I do not understand the part with pong - please elaborate with problem and example how added pong fixes it |
|
Hey there! Absolutely, we’ve got stats and metrics for our websockets bridge. We calculate the metrics for each socket right in their pong event callback. We've done it with other libraries, except for the centrifugo library. Let me know if you have any questions! |
|
Any news @FZambia? |
I am still guessing what exactly this allows to achieve and how it may be useful to other library users. Probably it's not the best solution to the root problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pongevent handling for server-side communication.