Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed kwarg #53

Merged
merged 1 commit into from
Mar 12, 2024
Merged

changed kwarg #53

merged 1 commit into from
Mar 12, 2024

Conversation

specktakel
Copy link
Collaborator

solves #52

@specktakel specktakel requested a review from cescalara March 12, 2024 08:42
@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 55.33%. Comparing base (e13e5f0) to head (5405cb1).

Files Patch % Lines
icecube_tools/detector/effective_area.py 47.36% 10 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   55.33%   55.33%           
=======================================
  Files          24       24           
  Lines        4384     4384           
=======================================
  Hits         2426     2426           
  Misses       1958     1958

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cescalara cescalara merged commit 45c1c9c into cescalara:master Mar 12, 2024
6 checks passed
@specktakel specktakel deleted the fix-pd branch March 12, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescalara cescalara cescalara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@specktakel @cescalara