feat: improve image upload component #536
Merged
+155
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
AfonsoMartins26
requested review from
joaodiaslobo,
nunom27,
MarioRodrigues10 and
FilipeR13
FilipeR13
previously approved these changes
Oct 3, 2024
AfonsoMartins26
changed the title
joaodiaslobo
previously requested changes
Oct 3, 2024
MarioRodrigues10
requested changes
Feb 20, 2025
MarioRodrigues10
requested changes
Feb 21, 2025
There was a problem hiding this comment.
I uploaded an image of 22kb and then a 220kb image as a profile picture, and it doesn't showed any error in the UI but phoenix returned the following error.
** (CaseClauseError) no case clause matching: {:error, #Ecto.Changeset<action: :update, changes: %{}, errors: [profile_picture: {"file size exceeds maximum allowed size", [type: Atomic.Uploaders.ProfilePicture.Type, validation: :cast]}], data: #Atomic.Accounts.User<>, valid?: false, ...>}
MarioRodrigues10
requested changes
Feb 27, 2025
MarioRodrigues10
requested changes
Feb 27, 2025
MarioRodrigues10
requested changes
Feb 28, 2025
MarioRodrigues10
requested changes
Feb 28, 2025
MarioRodrigues10
requested changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.