Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Add suffix to Half library name #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bryab
Copy link

@bryab bryab commented May 6, 2019

This was necessary for me to build on macOS.

@cessen
Copy link
Owner

cessen commented May 7, 2019

Hmm... that's odd. I wonder if the Ilm libraries build with different names on MacOS? On Linux on my machine, the library files are named like so (building them from source):

libHalf.a      libIexMath-2_2.a     libIlmThread-2_2.a
libHalf.la     libIexMath-2_2.la    libIlmThread-2_2.la
libIex-2_2.a   libIlmImf-2_2.a      libImath-2_2.a
libIex-2_2.la  libIlmImfUtil-2_2.a  libImath-2_2.la

The libHalf library files don't have the -2_2 suffix. So I think this PR would break things on Linux...? Can you double-check what your library files are named?

@bryab
Copy link
Author

bryab commented May 7, 2019

Hey, I think this is an issue with version 2.3. Just tried building on Linux, and I got:

openexr2.3/lib/libIex-2_3_s.a
openexr2.3/lib/libIlmImf-2_3_s.a
openexr2.3/lib/libIexMath-2_3_s.a
openexr2.3/lib/libHalf-2_3_s.a
openexr2.3/lib/libIlmImfUtil-2_3_s.a
openexr2.3/lib/libImath-2_3_s.a
openexr2.3/lib/libIlmThread-2_3_s.a

@norru
Copy link
Contributor

norru commented May 9, 2019

My guess: there should be an option in the build to remove the suffix which is now the default but wasn't in previous versions. Could be unintentional from the lib's maintainer. I think the version suffix shouldn't be used.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants