Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-11166: Remove ShellCheck from centos-7, it is too old to work with our shellcheck annotations. #1370

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

craigcomstock
Copy link
Contributor

Ticket: ENT-11166

@craigcomstock
Copy link
Contributor Author

canary rhel-7 failed in nightlies, "fixed" this on the CI vms directly for now and we can regen them tomorrow

00:59:06 /usr/bin/shellcheck
00:59:06 ShellCheck - shell script analysis tool
00:59:06 version: 0.3.8
00:59:06 license: GNU General Public License, version 3
00:59:06 website: http://www.shellcheck.net/
00:59:06 
00:59:06 In cf-support line 386:
00:59:06 if [ -f $WORKDIR/share/cf-support-nova-hub.sh ]; then
00:59:06                                                  ^-- SC1009: The mentioned parser error was in this then clause.
00:59:06 
00:59:06 
00:59:06 In cf-support line 387:
00:59:06   # shellcheck source=/dev/null
00:59:06   ^-- SC1073: Couldn't parse this shellcheck annotation.
00:59:06                ^-- SC1072: Expected "disable". Fix any mentioned problems and try again.
00:59:06 
00:59:06 gmake[4]: *** [check-local] Error 1
00:59:06 gmake[3]: *** [check-am] Error 2

@craigcomstock craigcomstock merged commit 5a63ac9 into master Jan 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant