ENT-11233: Aborted package installation if backup directory exists non-empty (3.21) #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have observed the presence of an old backup directory causing issues during upgrade. This change avoids proceeding with package installation if a backup directory exists and is not empty. Previously this was restricted to when we thought we would be doing a database migration, but we have seen issues with failed migration when the backup directory is non-empty and we are not doing any migration, so it is better to simply avoid installing the package if the backup directory is not empty even if we don't expect to use it for migration. Ticket: ENT-11233 Changelog: Title (cherry picked from commit b7364b8)
|
For #1394 |
|
@cf-bottom jenkins, please. |
The gh actions are failing here. |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10819/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10819/ |
|
@nickanderson jenkins failure looks unrelated, I added a ticket for it: https://northerntech.atlassian.net/browse/ENT-11829 |
craigcomstock
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed the presence of an old backup directory causing issues during
upgrade. This change avoids proceeding with package installation if a backup
directory exists and is not empty.
Previously this was restricted to when we thought we would be doing a database
migration, but we have seen issues with failed migration when the backup
directory is non-empty and we are not doing any migration, so it is better to
simply avoid installing the package if the backup directory is not empty even if
we don't expect to use it for migration.
Ticket: ENT-11233
Changelog: Title
(cherry picked from commit b7364b8)