Added sudo skipping when UID is zero #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@victormlg maybe this incoming documentation would help!? https://github.com/cfengine/documentation/pull/3355/files |
victormlg
force-pushed
the
CFE-4464-check-sudo
branch
from
e22f73f to
a254766
Compare
Thanks! |
olehermanse
requested changes
Jan 2, 2025
cf_remote/ssh.py
Outdated
| @@ -18,6 +18,7 @@ class LocalConnection: | |||
|
|
|||
| def __init__(self): | |||
| self.ssh_user = pwd.getpwuid(os.getuid()).pw_name | |||
| self.has_sudo = self.run("echo $UID", hide=True).stdout.strip() != '0' | |||
There was a problem hiding this comment.
The name, has_sudo, is not good. It sounds like it means that you have the sudo program. I would choose something else, like needs_sudo, is_not_uid_zero or is_non_root;
Suggested change
| self.has_sudo = self.run("echo $UID", hide=True).stdout.strip() != '0' | |
| self.needs_sudo = self.run("echo $UID", hide=True).stdout.strip() != '0' |
Ticket: CFE-4464 Signed-off-by: Victor Moene <[email protected]>
victormlg
force-pushed
the
CFE-4464-check-sudo
branch
from
53c9b9b to
49432f4
Compare
olehermanse
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't test on a minimal centos 9 container, because I don't how to spawn them.