Added check if binaries are in path #109
Conversation
cf_remote/remote.py
Outdated
| @@ -600,13 +600,23 @@ def deploy_masterfiles(host, tarball, *, connection=None): | |||
| scp(tarball, host, connection=connection, rename="masterfiles.tgz") | |||
| tarball = "masterfiles.tgz" | |||
| ssh_cmd(connection, "tar -xzf %s" % tarball) | |||
|
|
|||
| cfagent_path = "" | |||
| if not ssh_cmd(connection, "command -v cf-agent"): | |||
There was a problem hiding this comment.
Here, we check if cf-agent is in PATH for the user we logged in as. However, we execute the commands below as root. Hence, cf-agent may still not be in PATH for the root user. Thus, we need to do this command as root as well.
There was a problem hiding this comment.
Do I need to use sudo when doing if ssh_cmd(connection, "command -v /var/cfengine/bin/cf-agent"): ?
There was a problem hiding this comment.
Nope, because that you are not using the PATH environment variable :)
|
It would be nice if we printed an error if |
I created a ticket here: https://northerntech.atlassian.net/browse/CFE-4480 |
Ticket: CFE-4446 Signed-off-by: Victor Moene <[email protected]>
victormlg
force-pushed
the
CFE-4446-check-binaries-in-path
branch
from
7521671 to
cf2e698
Compare
No description provided.