Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement vector potential calcs #7

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Implement vector potential calcs #7

merged 4 commits into from
Aug 29, 2024

Conversation

jlogan-cfs
Copy link
Collaborator

2.1.0 2024-08-27

Added

  • Add vector potential calcs for linear and circular filaments
  • Add parallel options for circular-filament calcs
  • Add parametrization of unit tests over parallel and serial variants
  • Add optional parallel flags to functions that use functions with new parallel options

@jlogan-cfs
Incorporate new vector potential calcs, add parallel variants of circ…
9cf638f 
…ular filament functions, update deps and tests, roll minor version
@jlogan-cfs jlogan-cfs changed the base branch from release to develop August 28, 2024 19:45
mvernacc
mvernacc reviewed Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@mvernacc mvernacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one place where the units need to be fixed in a comment, and the docs need to be updated. Otherwise this looks great.

test/test_electromagnetics.py Outdated Show resolved Hide resolved
@jlogan-cfs jlogan-cfs merged commit de43a3e into develop Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvernacc mvernacc mvernacc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlogan-cfs @mvernacc