Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundles): do not store full chain #1787

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

jiparis
Copy link
Member

@jiparis jiparis commented Feb 7, 2025

Sigstore bundles v3.0 should only contain the leaf certificate used for signing. Intermediates and root certificates must be trusted and provided out-of-band.

https://github.com/sigstore/protobuf-specs/blob/main/protos/sigstore_bundle.proto#L91

Signed-off-by: Jose I. Paris <[email protected]>
Signed-off-by: Jose I. Paris <[email protected]>
Signed-off-by: Jose I. Paris <[email protected]>
@jiparis jiparis requested review from migmartri and javirln February 7, 2025 01:40
@jiparis jiparis merged commit 9c5892c into chainloop-dev:main Feb 7, 2025
13 checks passed
@jiparis jiparis deleted the pfm-2283-fix branch February 7, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants