Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-server): auto complete complex utility values #72

Merged
merged 1 commit into from
Feb 24, 2025
Merged

fix(language-server): auto complete complex utility values #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pink-grapes-love.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@pandacss/language-server': minor
---

auto complete utilities with complex tokens
254 changes: 254 additions & 0 deletions packages/language-server/__tests__/get-completion-for.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,3 +504,257 @@ test('display: block', () => {
]
`)
})

test('width: xl', () => {
const ctx = createContext()
expect(getCompletionFor({ ctx, propName: 'width', propValue: 'x', settings: {} })).toMatchInlineSnapshot(`
[
{
"data": {
"propName": "width",
"shorthand": undefined,
"token": _Token {
"deprecated": undefined,
"description": undefined,
"extensions": {
"category": "sizes",
"condition": "base",
"pixelValue": "320px",
"prop": "xs",
"var": "--sizes-xs",
"varRef": "var(--sizes-xs)",
},
"name": "sizes.xs",
"originalValue": "20rem",
"path": [
"sizes",
"xs",
],
"type": undefined,
"value": "20rem",
},
},
"kind": 20,
"label": "xs",
"preselect": false,
"sortText": "-xs",
},
{
"data": {
"propName": "width",
"shorthand": undefined,
"token": undefined,
},
"kind": 20,
"label": "xl",
"preselect": false,
"sortText": "-xl",
},
{
"data": {
"propName": "width",
"shorthand": undefined,
"token": _Token {
"deprecated": undefined,
"description": undefined,
"extensions": {
"category": "sizes",
"condition": "base",
"pixelValue": "672px",
"prop": "2xl",
"var": "--sizes-2xl",
"varRef": "var(--sizes-2xl)",
},
"name": "sizes.2xl",
"originalValue": "42rem",
"path": [
"sizes",
"2xl",
],
"type": undefined,
"value": "42rem",
},
},
"kind": 20,
"label": "2xl",
"preselect": false,
"sortText": "-0000000000002xl",
},
{
"data": {
"propName": "width",
"shorthand": undefined,
"token": undefined,
},
"kind": 20,
"label": "3xl",
"preselect": false,
"sortText": "-0000000000003xl",
},
{
"data": {
"propName": "width",
"shorthand": undefined,
"token": _Token {
"deprecated": undefined,
"description": undefined,
"extensions": {
"category": "sizes",
"condition": "base",
"pixelValue": "896px",
"prop": "4xl",
"var": "--sizes-4xl",
"varRef": "var(--sizes-4xl)",
},
"name": "sizes.4xl",
"originalValue": "56rem",
"path": [
"sizes",
"4xl",
],
"type": undefined,
"value": "56rem",
},
},
"kind": 20,
"label": "4xl",
"preselect": false,
"sortText": "-0000000000004xl",
},
{
"data": {
"propName": "width",
"shorthand": undefined,
"token": undefined,
},
"kind": 20,
"label": "5xl",
"preselect": false,
"sortText": "-0000000000005xl",
},
{
"data": {
"propName": "width",
"shorthand": undefined,
"token": _Token {
"deprecated": undefined,
"description": undefined,
"extensions": {
"category": "sizes",
"condition": "base",
"pixelValue": "1152px",
"prop": "6xl",
"var": "--sizes-6xl",
"varRef": "var(--sizes-6xl)",
},
"name": "sizes.6xl",
"originalValue": "72rem",
"path": [
"sizes",
"6xl",
],
"type": undefined,
"value": "72rem",
},
},
"kind": 20,
"label": "6xl",
"preselect": false,
"sortText": "-0000000000006xl",
},
{
"data": {
"propName": "width",
"shorthand": undefined,
"token": undefined,
},
"kind": 20,
"label": "7xl",
"preselect": false,
"sortText": "-0000000000007xl",
},
{
"data": {
"propName": "width",
"shorthand": undefined,
"token": _Token {
"deprecated": undefined,
"description": undefined,
"extensions": {
"category": "sizes",
"condition": "base",
"pixelValue": "1440px",
"prop": "8xl",
"var": "--sizes-8xl",
"varRef": "var(--sizes-8xl)",
},
"name": "sizes.8xl",
"originalValue": "90rem",
"path": [
"sizes",
"8xl",
],
"type": undefined,
"value": "90rem",
},
},
"kind": 20,
"label": "8xl",
"preselect": false,
"sortText": "-0000000000008xl",
},
{
"data": {
"propName": "width",
"shorthand": undefined,
"token": undefined,
},
"kind": 20,
"label": "max",
"preselect": false,
"sortText": "-max",
},
{
"data": {
"propName": "width",
"shorthand": undefined,
"token": _Token {
"deprecated": undefined,
"description": undefined,
"extensions": {
"category": "sizes",
"condition": "base",
"pixelValue": "1280px",
"prop": "breakpoint-xl",
"var": "--sizes-breakpoint-xl",
"varRef": "var(--sizes-breakpoint-xl)",
},
"name": "sizes.breakpoint-xl",
"originalValue": "1280px",
"path": [
"sizes",
"breakpoint-xl",
],
"type": undefined,
"value": "1280px",
},
},
"kind": 20,
"label": "breakpoint-xl",
"preselect": false,
"sortText": "-breakpoint-xl",
},
{
"data": {
"propName": "width",
"shorthand": undefined,
"token": undefined,
},
"kind": 20,
"label": "breakpoint-2xl",
"preselect": false,
"sortText": "-breakpoint1000000000002xl",
},
]
`)
})
25 changes: 20 additions & 5 deletions packages/language-server/src/completion-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,28 @@ export const getCompletionFor = ({
category = utility.values
} else if (typeof utility.values === 'function') {
// values: (theme) => { ...theme("spacing") }
const record = ctx.utility.getPropertyValues(utility, (cat) => {
category = cat
return cat
const record = ctx.utility.getPropertyValues(utility, (key) => {
return `types:Tokens["${key}"]`
Comment on lines +154 to +155
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used similar function from panda/core

https://github.com/chakra-ui/panda/blob/465eb9c480be3e5ba8e232f06b346e1f1ab5b474/packages/core/src/utility.ts#L340

})
if (record) {
if (record.type) category = record.type as string
else propValues = record as Record<string, string>
if (record.type) {
category = record.type as string
} else {
const newRecord: Record<string, string> = {}
// itterate through record keys and extract sub values if they are present
Object.entries(record as Record<string, string | {}>).forEach(([name, value]) => {
if (typeof value === 'string') {
newRecord[name] = value
return
}
// flatten token
Object.entries(value as Record<string, string>).forEach(([subName, subValue]) => {
newRecord[subName] = subValue
})
return
})
propValues = newRecord
}
}
}
}
Expand Down