fix: allow passing in inherited float values (#2552)

* fix: allow passing in inherited float values * docs: add changeset --------- Co-authored-by: Segun Adebayo <[email protected]>
chakra-ui · May 1, 2024 · 2116abe · 2116abe
1 parent 33cf5bd
commit 2116abe
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/fresh-eggs-kneel.md b/.changeset/fresh-eggs-kneel.md
@@ -0,0 +1,7 @@
+---
+"@pandacss/generator": patch
+"@pandacss/preset-base": patch
+"@pandacss/studio": patch
+---
+
+Fix issue where `float` property did not allow inherited values (auto, initial, none, etc.)
diff --git a/packages/generator/__tests__/generate-prop-types.test.ts b/packages/generator/__tests__/generate-prop-types.test.ts
@@ -22,7 +22,7 @@ describe('generate property types', () => {
       	insetInlineStart: Tokens["spacing"];
       	right: Tokens["spacing"];
       	bottom: Tokens["spacing"];
-      	float: "left" | "right" | "start" | "end";
+      	float: "start" | "end" | CssProperties["float"];
       	hideFrom: Tokens["breakpoints"];
       	hideBelow: Tokens["breakpoints"];
       	flexBasis: Tokens["spacing"] | "1/2" | "1/3" | "2/3" | "1/4" | "2/4" | "3/4" | "1/5" | "2/5" | "3/5" | "4/5" | "1/6" | "2/6" | "3/6" | "4/6" | "5/6" | "1/12" | "2/12" | "3/12" | "4/12" | "5/12" | "6/12" | "7/12" | "8/12" | "9/12" | "10/12" | "11/12" | "full";

diff --git a/packages/preset-base/src/utilities/layout.ts b/packages/preset-base/src/utilities/layout.ts
@@ -117,7 +117,8 @@ export const layout: UtilityConfig = {
   },
   float: {
     className: 'float',
-    values: ['left', 'right', 'start', 'end'],
+    values: ['start', 'end'],
+    property: 'float',
     group: 'Position',
     transform(value) {
       if (value === 'start') {

diff --git a/packages/studio/styled-system/types/prop-type.d.ts b/packages/studio/styled-system/types/prop-type.d.ts
@@ -16,7 +16,7 @@ export interface UtilityValues {
 	insetInlineStart: Tokens["spacing"];
 	right: Tokens["spacing"];
 	bottom: Tokens["spacing"];
-	float: "left" | "right" | "start" | "end";
+	float: "start" | "end" | CssProperties["float"];
 	hideFrom: Tokens["breakpoints"];
 	hideBelow: Tokens["breakpoints"];
 	flexBasis: Tokens["spacing"] | "1/2" | "1/3" | "2/3" | "1/4" | "2/4" | "3/4" | "1/5" | "2/5" | "3/5" | "4/5" | "1/6" | "2/6" | "3/6" | "4/6" | "5/6" | "1/12" | "2/12" | "3/12" | "4/12" | "5/12" | "6/12" | "7/12" | "8/12" | "9/12" | "10/12" | "11/12" | "full";