Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration with travis-ci and publish binaries #68

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

lpaulmp
Copy link
Contributor

@lpaulmp lpaulmp commented Apr 23, 2019

Closes issues #67 # #61

This PR adds the integrations with travis-ci and executes the suite test for all branches when travis-ci detects that a new tag has been pushed runsstack build, stack test and create a new release and uploads the binaries built for osx and Linux.
The format will be vaultenv-v$version-$os (vaultenv-v0.9.1-osx) I tested forking the repo and trying by myself

Screen Shot 2019-04-23 at 14 38 34

To create the release, you will need to define two environment variables in travis-ci:

  • A user that have permissions over the repo $GITHUB_USER = lpaulmp
  • Generate a Github token with permissions over the repo $GITHUB_TOKEN = mytoken1234.

@duijf I hope you find this useful

@lpaulmp
Copy link
Contributor Author

lpaulmp commented Apr 23, 2019

This is the build in travis-ci.

@duijf
Copy link
Contributor

duijf commented Apr 24, 2019

Thanks a lot for this PR! This looks very useful.

I have a few questions:

  • What specific OS versions is this actually running on? Can we pin this?
  • What do the binaries need to run (e.g. minimum/specific libc version)?
  • Would there be an easy way to extend this to run the integration tests (maybe against a list of Vault versions)? Might be out of scope here

@lpaulmp
Copy link
Contributor Author

lpaulmp commented Apr 24, 2019

the default OS are Ubuntu Trusty 14.04 and macOS 10.13 xcode9.4 these are pretty compatible with most of the Linux and macos machines.

What specific OS versions is this actually running on? Can we pin this?

Yes, we can pin specific versions adding a matrix but I think this would fine for now so then we can add specific release according to the community needs.
example:

matrix:
  include:
    - os: linux
      dist: trusty
    - os: osx
      osx_image: xcode7.2

What do the binaries need to run (e.g. minimum/specific libc version)?

The binaries will need minimum the versions that you find in ubuntu 14.04 (pretty older version) or mac os 10.13. Most of the Linux distros have this version installed in server/desktops so update the os version to the latest ubuntu LTS/macos would lose some compatibility for other users.

Would there be an easy way to extend this to run the integration tests

yes, you can extend the scope of the test. You can add more entries in the Travis file to execute the test that you are interested in.

@duijf
Copy link
Contributor

duijf commented Jun 7, 2019

Hey! Now that #65 is merged, we have a reason to test this one out :)

Thanks a lot for the effort! I'll merge this one and will see if I can get it to work for us!

@duijf duijf merged commit a86a922 into channable:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants