-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add test that filters on deposition page at least render #1451
Open
bchu1
wants to merge
1
commit into
main
Choose a base branch
from
bchu/filtertest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
62 changes: 62 additions & 0 deletions
62
frontend/packages/data-portal/e2e/depositionFilters.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
import { test } from '@playwright/test' | ||
|
||
import { SINGLE_DEPOSITION_URL } from './constants' | ||
import { goTo } from './filters/utils' | ||
import { FiltersActor } from './pageObjects/filters/filtersActor' | ||
import { FiltersPage } from './pageObjects/filters/filtersPage' | ||
|
||
test.describe('Deposition page filters:', () => { | ||
let filtersPage: FiltersPage | ||
let filtersActor: FiltersActor | ||
|
||
test.beforeEach(async ({ page }) => { | ||
filtersPage = new FiltersPage(page) | ||
filtersActor = new FiltersActor(filtersPage) | ||
|
||
await goTo(page, SINGLE_DEPOSITION_URL) | ||
}) | ||
|
||
test('Organism name filter renders', async () => { | ||
await filtersActor.addSingleSelectFilter({ | ||
label: 'Organism Name', | ||
value: 'Homo sapiens', | ||
}) | ||
}) | ||
|
||
test('Object name filter renders', async () => { | ||
await filtersActor.addSingleSelectFilter({ | ||
label: 'Object Name', | ||
value: 'vesicle', | ||
}) | ||
}) | ||
|
||
test('Shape type filter renders', async () => { | ||
await filtersActor.addSingleSelectFilter({ | ||
label: 'Object Shape Type', | ||
value: 'Point', | ||
}) | ||
}) | ||
|
||
test('Camera manufacturer filter renders', async () => { | ||
await filtersActor.addSingleSelectFilter({ | ||
label: 'Camera Manufacturer', | ||
value: 'Gatan', | ||
}) | ||
}) | ||
|
||
test('Reconstruction method filter renders', async () => { | ||
await filtersActor.addSingleSelectFilter({ | ||
label: 'Reconstruction Method', | ||
value: 'WBP', | ||
}) | ||
}) | ||
|
||
test('Reconstruction software filter renders', async () => { | ||
await filtersActor.addSingleSelectFilter({ | ||
label: 'Reconstruction Software', | ||
value: 'IMOD', | ||
}) | ||
}) | ||
|
||
// TODO: More tests. | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should have some sort of "expect" right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just testing that the user can click on them. Didn't want to make any assertions on the resulting data just yet.