Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add module 02 activity #53

Merged
merged 5 commits into from
Jul 25, 2023
Merged

✨ Add module 02 activity #53

merged 5 commits into from
Jul 25, 2023

Conversation

trallard
Copy link
Collaborator

Closes #26

@trallard trallard requested a review from pavithraes July 24, 2023 10:43
pavithraes
pavithraes approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @trallard! This looks good to me. I've shared a couple of inline comments, and there is a small merge conflict (from #51) needs resolution. We can merge after that!

02-participating-in-oss/OSS-journey-activity.md Outdated Show resolved Hide resolved
02-participating-in-oss/OSS-journey-activity.md Outdated Show resolved Hide resolved
@trallard trallard force-pushed the trallard/module-02-activity branch from 033f12f to 56fd8a5 Compare July 25, 2023 08:48
@trallard
Copy link
Collaborator Author

Ok did a quick rebase so all should be aligned now

@pavithraes
Copy link
Collaborator

Thank you, this looks great! Merging :)

@pavithraes pavithraes merged commit 8cee6bf into trallard/2.01-why-contribute Jul 25, 2023
@pavithraes pavithraes deleted the trallard/module-02-activity branch July 25, 2023 11:31
trallard added a commit that referenced this pull request Jul 27, 2023
@trallard @pavithraes
✨ Chapter 2.01 - Why and how to contribute to OSS (#44)
f780a46 
* ✨ Start chapter 2.01

* ✨ Start chapter 2.01

* 📝 Add module 02 activity

* ✨ Start chapter 2.01

* 📝 Add module 02 activity

* Add activity instructions

* 📝 Add x-refs to docs (#49)

* ✨ Start chapter 2.01

* 📝 Add module 02 activity

* Add activity instructions

* 📝 Add section: Why contribute to OSS? (#50)

Co-authored-by: Tania Allard <[email protected]>

* 📝 Add section: Individual vs organizational contributions (#51)

Co-authored-by: Tania Allard <[email protected]>

* ✨ Add module 02 activity (#53)

Co-authored-by: Pavithra Eswaramoorthy <[email protected]>

* 🚚 Rename chapter file

* 📝 Replace meta for table

---------

Co-authored-by: Pavithra Eswaramoorthy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavithraes pavithraes pavithraes approved these changes

Assignees
No one assigned
Labels
status: merge ready 🚀 task ✅ type: new content 📝
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trallard @pavithraes