perf: updated & removed unused dependencies #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart-sass is deprecated and was moved to the main sass repo 3 years ago webpack i allready a dep of vuepress vuepress plugins except chart were never loaded
roikiermedia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of unused and outdated dependencies from copy-pasting this project from its original repo. This pull request removes and updates those.
We should also think about using the (still in beta?!) 2.x version of vuepress or switch to another static site builder (and maybe create a real template repo to bootstrap such small sites), as vuepress 1.x has a lot of deprecated dependencies. This has no security implications for us, as we only ship static builds, but should not be ignored for the long run.
Also we should think about purging sass. sass, even in its new implementation, is really slow and buggy. (For example, the newest version of Bootstrap uses deprecated language features and upgrading the sass-loader to newer versions tends to break the build process.) The only sass features used here are variables, wich are now a part of CSS, and rule nesting, wich can be avoided easily by slight restructuring of the stylesheets or isn't even needed in most cases in this repo.
This also closes #2, #3 & #6.