Document Python stdout/stderr buffering behavior #26624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
jabraham17
changed the title
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
DanilaFe
approved these changes
Feb 3, 2025
| @@ -90,7 +91,7 @@ proc test_three_args_with_default_and_kwargs(mod: borrowed Module) { | |||
| func(NoneType, 8, kwargs=["b" => 10]); | |||
| func(NoneType, 8, kwargs=["c" => 11, "abc" => 12]); | |||
| } | |||
| proc test_varargs_and_kwargs(mod: borrowed Module) { | |||
| proc test_varargs_and_kwargs(mod: borrowed Module, flush: borrowed Value) { | |||
There was a problem hiding this comment.
can't you make flush a global variable instead of threading it through?
There was a problem hiding this comment.
Yes, but that would require making interp a global variable as well
There was a problem hiding this comment.
That makes me think of two things, in ascending order of quality:
- Can you make
interpglobal :3 - What if
interphad a flush method, so that you didn't have to use aValuein user code? Given that you'd need to do this for all interspersed IO, I think it might be worth it.
There was a problem hiding this comment.
I know this is just a test, but I dislike making interp global. However, I do find adding interp.flush() appealing. Value is definitely a user facing type, but having interp.flush() still seems like a useful helper.
Signed-off-by: Jade Abraham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the behavior of IO with Chapel and Python interspersed, and tell users how to deal with it.
start_test test/library/packages/Pythonstart_test test/library/packages/Pythonwith GASNet[Reviewed by @DanilaFe]