Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a skipif for this test with --fast, it relies on bounds checking #26648

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

lydia-duncan
Copy link
Member

@lydia-duncan lydia-duncan commented Feb 4, 2025

Passed a fresh checkout of the test with and without --fast

@lydia-duncan lydia-duncan merged commit 8344394 into chapel-lang:main Feb 4, 2025
8 checks passed
@lydia-duncan lydia-duncan deleted the fixTestFailure branch February 4, 2025 20:51
@bradcray
Copy link
Member

bradcray commented Feb 4, 2025

An alternate technique that we've been trying to use for cases like this is to add a compopts with --checks in it so that the test is checking what it's designed to regardless of how it's run (including a user-supplied -compopts flag on their start_test run like --compopts --no-checks).

(even when using a skipif for cases like this, I always suggest reaching for a suppressif instead so that if the test suddenly starts passing in fast testing, we learn that --fast isn't turning off bounds checking anymore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants