Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder notifications in nightly email to better reflect priority #26682

Merged
merged 1 commit into from
Feb 10, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions util/cron/nightlysubs.pm
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,17 @@ sub writeEmail {
print $SF endMailHeader();
print $SF "--- New Errors -------------------------------\n";
print $SF `LC_ALL=C comm -13 $prevsummary $sortedsummary | grep -v "^.Summary:" | grep -v "$futuremarker" | grep -v "$suppressmarker"`;
print $SF `LC_ALL=C comm -13 $prevmysystemlog $sortedmysystemlog`;
print $SF "\n";

print $SF "--- Resolved Errors --------------------------\n";
print $SF `LC_ALL=C comm -23 $prevsummary $sortedsummary | grep -v "^.Summary:" | grep -v "$futuremarker" | grep -v "$suppressmarker"`;
print $SF `LC_ALL=C comm -23 $prevmysystemlog $sortedmysystemlog`;
print $SF "\n";

print $SF "--- Unresolved Errors ------------------------\n";
print $SF `LC_ALL=C comm -12 $prevsummary $sortedsummary | grep -v "^.Summary:" | grep -v "$futuremarker" | grep -v "$suppressmarker"`;
print $SF `LC_ALL=C comm -12 $prevmysystemlog $sortedmysystemlog`;
print $SF "\n";

print $SF "--- New Passing Future tests------------------\n";
Expand All @@ -189,25 +196,10 @@ sub writeEmail {
print $SF `LC_ALL=C comm -12 $prevsummary $sortedsummary | grep -v "^.Summary:" | grep "$suppressmarker" | grep "\\[Success"`;
print $SF "\n";

print $SF "--- Unresolved Errors ------------------------\n";
print $SF `LC_ALL=C comm -12 $prevsummary $sortedsummary | grep -v "^.Summary:" | grep -v "$futuremarker" | grep -v "$suppressmarker"`;
print $SF "\n";

print $SF "--- New Failing Future tests -----------------\n";
print $SF `LC_ALL=C comm -13 $prevsummary $sortedsummary | grep -v "^.Summary:" | grep "$futuremarker" | grep "\\[Error"`;
print $SF "\n";

print $SF "--- New Errors in Bash Commands ------------------\n";
print $SF `LC_ALL=C comm -13 $prevmysystemlog $sortedmysystemlog`;
print $SF "\n";

print $SF "--- Unresolved Errors in Bash Commands ------------------\n";
print $SF `LC_ALL=C comm -12 $prevmysystemlog $sortedmysystemlog`;
print $SF "\n";

print $SF "--- Resolved Errors in Bash Commands ------------------\n";
print $SF `LC_ALL=C comm -23 $prevmysystemlog $sortedmysystemlog`;
print $SF "\n";
print $SF;
print $SF endMailChplenv();
close($SF);
Expand Down